RUM-17613: timeseries [3/5] Pass the live RUM context to timeseries pipelines - #3717
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 340e8c5 | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/timeseries #3717 +/- ##
======================================================
+ Coverage 73.34% 73.37% +0.03%
======================================================
Files 1012 1012
Lines 37027 37029 +2
Branches 6381 6380 -1
======================================================
+ Hits 27154 27167 +13
+ Misses 8046 8041 -5
+ Partials 1827 1821 -6
🚀 New features to boost your workflow:
|
2c34b26 to
61448ac
Compare
timeseries [3/4] Flush the batch in background
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61448ace2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
61448ac to
341c6b1
Compare
timeseries [3/4] Flush the batch in backgroundtimeseries [3/5] Pass the live RUM context to timeseries pipelines
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 341c6b1286
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
341c6b1 to
56c1714
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
56c1714 to
5e03b28
Compare
5e03b28 to
41475c9
Compare
Timeseries batches carried the RumContext captured when RumSessionScope created the collector, so every event was attributed to whatever view was active at session start. The collector now tracks the context and hands it to Pipeline.execute()/flush() per call, and RumSessionScope feeds it the active context on each handled event. Pipeline takes over its own synchronization as part of that: reader.read() stays outside the lock so a concurrent flush() never waits for /proc I/O. Ref: RUM-17613
41475c9 to
340e8c5
Compare

What does this PR do?
Timeseries batches carried the
RumContextcaptured whenRumSessionScopecreated the collector, so every event was attributed to whatever view happened to be active at session start. The collector now tracks the context and hands it toPipeline.execute()/Pipeline.flush()per call, andRumSessionScopefeeds it the active context on every handled event.Pipelinetakes over its own synchronization as part of that:reader.read()stays outside the lock, so a concurrentflush()waits only for the buffer and never for/procI/O.The sampling lifecycle is unchanged here — background suspension still behaves exactly as before, gated on
TimeseriesConfiguration.collectInBackground. [4/5] reworks it.Review checklist (to be filled by reviewers)
Ref: RUM-17613