Add biome tag for diving helmet fog scaling#10446
Closed
LTDigor wants to merge 1 commit into
Closed
Conversation
|
1.20 isn't supported anymore and won't receive further updates, as per https://wiki.createmod.net/users/development-status |
Collaborator
|
Per the above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a biome tag that lets specific biomes opt out of Create's diving helmet water fog distance scaling.
This keeps the existing water/lava event cancellation behavior scoped to the same branches, so other mods can continue handling fog when Create is not actively overriding it.
The default tag entry is optional and targets Alex's Caves'
alexscaves:abyssal_chasmbiome.A separate 1.21.1 draft PR is kept at #10445.
Old PR screenshots
Before:
After:
Testing
./gradlew compileJava./gradlew runData./gradlew runClient -PquickPlayWorld=Create_AlexCaves_1201_Fog_Test_2with ForgeGradle-remapped Alex's Caves 2.0.2 and Citadel 2.6.0 inrun/mods; the client selectedalexscaves.mixins.json, initialized Create 6.0.8, loaded Alex's Caves client resources, loaded the temporary test datapack, connected to the integrated modded server, and logged the player into the Quick Play world.