Skip to content

Add biome tag for diving helmet fog scaling#10445

Open
LTDigor wants to merge 1 commit into
Creators-of-Create:mc1.21.1/devfrom
LTDigor:codex/diving-helmet-fog-biome-tag
Open

Add biome tag for diving helmet fog scaling#10445
LTDigor wants to merge 1 commit into
Creators-of-Create:mc1.21.1/devfrom
LTDigor:codex/diving-helmet-fog-biome-tag

Conversation

@LTDigor

@LTDigor LTDigor commented Jun 2, 2026

Copy link
Copy Markdown

What changed

  • Replaces the old config-based approach from Add config for diving helmet scaling render distance #7917 with a biome tag gate for Create diving helmet water fog scaling.
  • Adds create:without_diving_helmet_fog_scaling for biomes where Create should not extend underwater fog distance.
  • Includes alexscaves:abyssal_chasm as an optional default tag entry, so Alex's Caves keeps its own low-visibility fog behavior when installed.

Screenshots from #7917

Before:

2025-03-12_10 48 10

After:

2025-03-12_10 48 35

Why

The previous PR disabled the behavior through config and also moved event.setCanceled(true) outside the fog branches. Review feedback asked for a biome tag instead and noted that canceling fog when Create does not handle it can break other mods. This version only skips the water scaling in tagged biomes and leaves event cancellation inside the existing water/lava handling branches.

Validation

  • ./gradlew compileJava
  • ./gradlew runData
  • Local client launch with Alex's Caves (Unofficial Port) 2.0.10 and Citadel 2.7.6 on NeoForge 21.1.219, using a fresh Quick Play creative test world with a datapack that filled the player area as alexscaves:abyssal_chasm, equipped a Create diving helmet, and surrounded the player with water. The client loaded Create, Alex's Caves, and Citadel together and entered the integrated world without a crash.

Notes from the runtime check: the copied template world logged unknown piglinproliferation/luminous_* data attachments; those came from the reused local template save and are unrelated to this change.

Related

@LTDigor LTDigor marked this pull request as ready for review June 2, 2026 15:08
@VoidLeech VoidLeech added pr type: feature PR adds a new feature or changes an existing feature pr flag: simple PR has minimal changes labels Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr flag: simple PR has minimal changes pr type: feature PR adds a new feature or changes an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants