🐛 fix(docker): update Alpine tzdata pin#523
Merged
Merged
Conversation
scttbnsn
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
July 14, 2026 04:28
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated the Dockerfile’s Alpine 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
scttbnsn
added a commit
that referenced
this pull request
Jul 14, 2026
## Summary - update the Alpine 3.21 tzdata pin from 2026b-r0 to the currently available 2026c-r0 - add a regression that rejects the disappeared revision ## Why PR #532 exposed a deterministic fresh-build failure before Cucumber could start: Alpine now serves tzdata-2026c-r0, so the main Dockerfile pin to 2026b-r0 can no longer resolve. The retry failed identically. This is the main forward-port of the already accepted v1.6 fix from #523. It intentionally does not import unrelated v1.6 Trivy or Alpine changes. ## Verification - TDD red: Dockerfile defaults regression failed on 2026b-r0 - targeted regression passes after the pin update - fresh local image build from exact main succeeds and installs tzdata 2026c-r0 - independent audit confirms this two-file transplant is the minimal main-safe port; cherry-picking the dev commit wholesale would conflict with main-specific tests After this merges, #532 will be rebased on the repaired main SHA and rerun. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Changelog - 🔧 Changed Alpine 3.21 `tzdata` pin in the main Dockerfile from `2026b-r0` to `2026c-r0`. - ✨ Added a Docker regression test that parses the root `Dockerfile` `base` stage `apk add` line(s) to assert `tzdata=2026c-r0` (including the exact trailing line continuation formatting) and to ensure `tzdata=2026b-r0` is absent. - 🐛 Fixed deterministic fresh-build failures caused by the discontinued/unavailable `tzdata` package revision. ## Concerns - Ensure the regression test continues to match the `base` stage `apk add` formatting exactly (including trailing line continuation). - Confirm CI passes with the updated Dockerfile parsing/assertion logic in `app/configuration/dockerfile-defaults.test.ts`. - Validate that fresh no-cache Linux/amd64 builds and runtime inspection both show `tzdata-2026c-r0` installed. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
scttbnsn
added a commit
that referenced
this pull request
Jul 14, 2026
…534) The #523 tzdata `2026c-r0` pin landed on `dev/v1.6` without its changelog bullet, so the dated `[1.6.0-rc.1]` section shipped no mention of the image-build failure it fixes. This adds the bullet under **Fixed**, next to the related Trivy image-digest entry, referencing #523 and the post-GA main-side application #533. Found by the 2026-07-14 release-train correctness review: the v1.6 release consolidation (#522) sources its tree from the accepted dev head, so without this the rc.1 release notes silently omit a real shipped fix. Docs-only: no runtime change. Full local pre-push gate green (lint, qlty, scripts/workflow tests, app+ui 100% coverage, builds, zizmor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
After this merges, PR #522 will be rebuilt from the new accepted dev/v1.6 tree and its complete matrix restarted.
Changelog
tzdatapin from2026b-r0to2026c-r0.2026b-r0revision.Verification