π fix(docker): update Alpine tzdata pin on main#533
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: π Files selected for processing (1)
π§ Files skipped from review as they are similar to previous changes (1)
π WalkthroughWalkthroughThe Dockerfile updates the Alpine Possibly related PRs
π₯ Pre-merge checks | β 2β Passed checks (2 passed)
β¨ Finishing Touchesπ Generate docstrings
π§ͺ Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/configuration/dockerfile-defaults.test.ts`:
- Around line 10-14: Update the test covering the release image in the
base-stage assertion to extract or otherwise scope the Dockerfile content to the
base stage, then verify the exact apk package-install line pins tzdata to
2026c-r0. Keep the regression check rejecting 2026b-r0 within that scoped
install content rather than using document-wide toContain checks.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a6c7eea-cc25-4043-b1e1-e3776c01b6f7
π Files selected for processing (2)
Dockerfileapp/configuration/dockerfile-defaults.test.ts
|
Additional exact-head verification:
Hosted exact-head Cucumber remains the authoritative reproduction of the original failure. |
|
Deployment failed with the following error: Learn More: https://vercel.com/codeswhat?upgradeToPro=build-rate-limit |
There was a problem hiding this comment.
Actionable comments posted: 1
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/configuration/dockerfile-defaults.test.ts`:
- Line 16: Update the package-line assertion in the baseStage test to use `[
\t]+` instead of `\s+`, ensuring the regex matches only horizontal whitespace
around `tzdata=2026c-r0` and validates the exact continued package line.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 88a7392b-913c-4a6b-98cb-38e66118b703
π Files selected for processing (2)
Dockerfileapp/configuration/dockerfile-defaults.test.ts
π§ Files skipped from review as they are similar to previous changes (1)
- Dockerfile
β¦534) The #523 tzdata `2026c-r0` pin landed on `dev/v1.6` without its changelog bullet, so the dated `[1.6.0-rc.1]` section shipped no mention of the image-build failure it fixes. This adds the bullet under **Fixed**, next to the related Trivy image-digest entry, referencing #523 and the post-GA main-side application #533. Found by the 2026-07-14 release-train correctness review: the v1.6 release consolidation (#522) sources its tree from the accepted dev head, so without this the rc.1 release notes silently omit a real shipped fix. Docs-only: no runtime change. Full local pre-push gate green (lint, qlty, scripts/workflow tests, app+ui 100% coverage, builds, zizmor).
Summary
Why
PR #532 exposed a deterministic fresh-build failure before Cucumber could start: Alpine now serves tzdata-2026c-r0, so the main Dockerfile pin to 2026b-r0 can no longer resolve. The retry failed identically.
This is the main forward-port of the already accepted v1.6 fix from #523. It intentionally does not import unrelated v1.6 Trivy or Alpine changes.
Verification
After this merges, #532 will be rebased on the repaired main SHA and rerun.
Changelog
tzdatapin in the main Dockerfile from2026b-r0to2026c-r0.Dockerfilebasestageapk addline(s) to asserttzdata=2026c-r0(including the exact trailing line continuation formatting) and to ensuretzdata=2026b-r0is absent.tzdatapackage revision.Concerns
basestageapk addformatting exactly (including trailing line continuation).app/configuration/dockerfile-defaults.test.ts.tzdata-2026c-r0installed.