Skip to content

fix: unblock the 1.24.1 release PR CI #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peter-leonov-ch merged 4 commits into from
Oct 9, 2026
Merged

fix: unblock the 1.24.1 release PR CI #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5db6c2f
test(client-node): cap the mock server delay in the queued-abort test
peter-leonov-ch Oct 9, 2026
b1ac325
ci(bench-skill-rowbinary): keep polling ClickHouse when curl fails
peter-leonov-ch Oct 9, 2026
906cc1f
ci(bench-skill-rowbinary): only accept a version from a successful curl
peter-leonov-ch Oct 9, 2026
ef6d323
docs(typescript-lsp): note the language server's Node.js 22 requirement
peter-leonov-ch Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .claude/skills/typescript-lsp/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ description: >
`npm install` (see the `setup` skill) it is available via `npx` and uses the
workspace-local `typescript` (6.x) compiler, matching CI exactly.

The server (6.x) requires Node.js >= 22.22.2, newer than the repository's
Node 20 minimum; on Node 20 `npm install` only warns, but the server isn't supported there.

## Starting the server

From the repo root:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench-skill-rowbinary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ jobs:
grep -m1 'model name' /proc/cpuinfo || true
# The server may still be starting; poll briefly so the version is captured.
for _ in $(seq 1 30); do
chv=$(curl -s 'http://localhost:8123/?query=SELECT%20version()')
[ -n "$chv" ] && break
if chv=$(curl -sf 'http://localhost:8123/?query=SELECT%20version()') && [ -n "$chv" ]; then break; fi
chv=
sleep 1
done
echo "ClickHouse: ${chv:-<unavailable>}"
Expand Down
5 changes: 3 additions & 2 deletions packages/client-node/__tests__/integration/node_abort_queued_request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { ClickHouseClient } from "@clickhouse/client-common";
import type { ClickHouseClientConfigOptions } from "@clickhouse/client";
import type Stream from "stream";

// The server answers "SELECT <ms>" after <ms> milliseconds.
// The server answers "SELECT <ms>" after <ms> milliseconds, capped at 5 seconds.
describe("[Node.js] Aborting a request queued for a socket", () => {
let server: http.Server | undefined;
let client: ClickHouseClient<Stream.Readable> | undefined;
Expand All @@ -25,7 +25,8 @@ describe("[Node.js] Aborting a request queued for a socket", () => {
let body = "";
req.on("data", (chunk) => (body += chunk));
req.on("end", () => {
const delay = Number(/SELECT (\d+)/.exec(body)?.[1] ?? 0);
const requested = Number(/SELECT (\d+)/.exec(body)?.[1] ?? 0);
const delay = requested <= 5000 ? requested : 5000;
setTimeout(() => {
res.write("Ok.");
res.end();
Expand Down
Loading