Repository navigation
fix: unblock the 1.24.1 release PR CI - #1045
Merged
Merged
Conversation
CodeQL flagged the mock server's request-controlled setTimeout as high severity resource exhaustion, which blocks the release PR #1044 via the code scanning ruleset. The release branch is protected, so this lands on main separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The step runs under bash -e, so the first curl connection error while the server was still starting aborted the step instead of retrying. This failed the benchmarks check on the release PR #1044. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Failed curl requests with output can still terminate polling prematurely.
1 open finding
What changed in this PR
Unblocks release CI by hardening a test mock and benchmark startup polling.
Changes:
- Caps mock-server delays at five seconds.
- Prevents immediate shell failure when
curlcannot reach ClickHouse.
| File | Description |
|---|---|
packages/client-node/__tests__/integration/node_abort_queued_request.test.ts |
Bounds the queued-abort test delay. |
.github/workflows/bench-skill-rowbinary.yml |
Adjusts ClickHouse version polling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Without -f, an HTTP error body (e.g. 503 while the server starts) was taken as the version and ended the polling early. Addresses Copilot review feedback on #1045. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
typescript-language-server 6.x (bumped in #1029) requires Node.js >= 22.22.2, above the repository's Node 20 minimum. Addresses Copilot review feedback on #1044 (release PR); lands on main separately because #1044 targets the protected release branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curlsucceeds (benchmarksfailure on 1.24.1 release #1044)typescript-lspskill (Copilot comment on 1.24.1 release #1044)mainbecause 1.24.1 release #1044 targets the protectedreleasebranch🤖 Generated with Claude Code