Preserve reverse sign in transient tire slip - #17
Merged
Conversation
rhorvath02
force-pushed
the
fix/transient-slip-reverse
branch
from
August 6, 2026 01:08
15b65ef to
423cacc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
TransientSlipalready stores signed longitudinal deformation: its-Vsxforcing term reverses with mirrored wheel kinematics, while the positive regularized speed magnitude provides stable relaxation in both travel directions. Multiplyingu/sigma_kappaby an additionalVx_signerased that reverse sign and made mirrored forward/reverse overspeed report the same longitudinal-slip sign.Fix
Remove the redundant output sign multiplier and publish
kappa = u/sigma_kappa(subject to the existing clamp). This matches the sign convention used byKinematicSlipwhile retaining positive, stable relaxation damping throughsqrt(Vx^2 + V_min^2).Validation
kappaForward = +0.0998922941,kappaReverse = -0.0998922941, and symmetry error0under CI's solver settings; all three values now have physical baselines.+0.0797510forward and-0.0797510reverse with zero symmetry error throughout the transient.+/-0.1 m/s, regularized transient slip remained exactly mirrored at+/-0.0199623and agreed in sign withKinematicSlip.31/31initialization-baseline values.1018/1018initialization-baseline values.6.098631 s, retained only finite outputs, and kept minimum tire load positive at182.83 N.