Skip to content

Correct wheel alignment angle unit contract - #15

Merged
rhorvath02 merged 3 commits into
mainfrom
fix/wheel-angle-units
Aug 7, 2026
Merged

Correct wheel alignment angle unit contract#15
rhorvath02 merged 3 commits into
mainfrom
fix/wheel-angle-units

Conversation

@rhorvath02

Copy link
Copy Markdown
Member

Finding

Wheel toe and camber parameters were declared as SI radians while their API and all existing numerical use treated them as degrees. The current numerical path was functional, but the type contract allowed callers to supply radian values that would then be interpreted as degrees.

Fix

Declare the record fields as Modelica.Units.NonSI.Angle_deg and replace manual pi/180 arithmetic with explicit Modelica.Units.Conversions.from_deg calls where radian frame APIs are used.

Validation

  • A 2-degree toe / 3-degree camber regression compared the existing FixedRotation degree API with the explicit-radian Frames.axesRotations path; maximum axis error was exactly zero.
  • Stock VehicleSim output was byte-identical to main and reached QSS at 6.049508 s.
  • This is behavior-preserving for existing BobLib data, not a runtime optimization or a correction of the current default results.

@rhorvath02
rhorvath02 force-pushed the fix/wheel-angle-units branch from d03c324 to d2e699f Compare August 6, 2026 01:08
@rhorvath02
rhorvath02 merged commit ec349b3 into main Aug 7, 2026
2 checks passed
@rhorvath02
rhorvath02 deleted the fix/wheel-angle-units branch August 7, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant