Correct wheel alignment angle unit contract - #15
Merged
Conversation
rhorvath02
force-pushed
the
fix/wheel-angle-units
branch
from
August 6, 2026 01:08
d03c324 to
d2e699f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
Wheel toe and camber parameters were declared as SI radians while their API and all existing numerical use treated them as degrees. The current numerical path was functional, but the type contract allowed callers to supply radian values that would then be interpreted as degrees.
Fix
Declare the record fields as
Modelica.Units.NonSI.Angle_degand replace manualpi/180arithmetic with explicitModelica.Units.Conversions.from_degcalls where radian frame APIs are used.Validation
FixedRotationdegree API with the explicit-radianFrames.axesRotationspath; maximum axis error was exactly zero.