Preserve motor power sign in reverse operation - #12
Merged
Conversation
rhorvath02
force-pushed
the
fix/motor-reverse-power
branch
from
August 6, 2026 01:08
de02f6c to
a2a6814
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
The power-limited motor used a nonnegative shaft-speed magnitude to convert requested power into torque. In reverse rotation this made positive motoring power produce the wrong torque sign, and similarly inverted reverse regenerative operation.
Fix
Preserve shaft-speed sign when converting limited mechanical power to torque, expose a configurable low-speed regularization power, and give the torque actuator an explicit fixed zero start value.
Validation
+9345.616 W / -94.090 Nm; reverse regeneration is-10645.089 W / +107.173 Nm.tau_actinitialization warning is gone.