Repository navigation
Conversation
Net effect of the reverted conflict-tolerance experiment: the driver and CFG keep the surviving conflict-tolerant reads.
opam builds with 'dune build -p NAME', which is shorthand for --release; the -O3 lived only in the dev profile, so every opam-built bap was compiled with -g and no -O3.
RelocationRef has no getAddend on this LLVM; the ELF-specific ref does, and its addend is an Expected. The table row emitted is unchanged.
The ogre doc parse rejects every entry whose table the scheme does not declare; the addend rows made the whole doc unparseable.
The x86-64 target aliased EAX..EDI and their 16/8-bit parts but declared no R8D-R15D, R8W-R15W or R8B-R15B. Semantics that name operands through the target (the Lisp SSE intrinsics, e.g. CVTSI2SDrr_Int on %r12d) then read a fresh free variable R12D instead of the low bits of R12.
The scalar min/max replaced all 128 bits with the selected operand; the destination's upper quadword is preserved.
The double-width result temporary made RAX and RDX extracts of a concatenation; each register now takes its half directly.
Each x87 instruction lifts to an x87_* intrinsic over its memory operands and flags; FPU_CONTROL is declared as a target register.
A word wider than the memory's native stores was written with each chunk shifted one chunk too far and in the opposite byte order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
During lifting some fp x86 instructions to BIL the RIP is not resolved:
Fix
This pr adds the reg# function already in x86-64.lisp that resolves the PC to the bitwise-rrm macro
The reg# function hardcodes the value 8 for the instruction length, but x86 instructions have variable lenght,
so i added a primus lisp primitive that uses provides the instruction length in bytes that is already in Knowledge Base
and substituted the hardcoded values with that primitive
After fix