Skip to content

feat(auth): SMS opt-in disclosure for phone-first form (#944, A2P campaign alignment) #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developer-ainative merged 2 commits into from
Oct 7, 2026
Merged

feat(auth): SMS opt-in disclosure for phone-first form (#944, A2P campaign alignment) #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a2843a
feat(auth): add SMS opt-in disclosure under the phone-first form's ph…
Oct 7, 2026
b2f519f
docs(auth): correct otp.ts's doc comment — 937 is Builder's own numbe…
Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/modernist.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,7 +1300,7 @@
/* Editable profile settings + Danger Zone (#57). */
.m-settings-form { display: flex; flex-direction: column; gap: 16px; max-width: 440px; }
.m-select { padding: 10px 12px; border: 1.5px solid var(--neutral-line); font-family: var(--font-body); font-size: 14px; background: var(--color-surface); }
.m-field-hint { font-size: 11px; }
.m-field-hint { font-size: 11px; color: var(--text-muted); margin-top: 4px; }
.m-field-err { font-size: 11px; color: #b42318; }
/* #479: advisory (never blocking) name-collision notice — amber, distinct from the red m-field-err. */
.m-field-warn { font-size: 11px; color: #93650a; display: flex; flex-wrap: wrap; align-items: center; gap: 6px; }
Expand Down
1 change: 1 addition & 0 deletions components/build/screens/Auth.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,7 @@ export function Auth({ mode }: { mode: Extract<Screen, 'login' | 'signup' | 'for
onChange={(e) => setPrimaryPhone(e.target.value)}
placeholder="(512) 555-1234"
/>
<p className="m-field-hint">We&apos;ll text you a one-time code to verify this number.</p>
</label>
{phoneFormError && <p className="m-auth-error">{phoneFormError}</p>}
{mode === 'signup' && (
Expand Down
19 changes: 14 additions & 5 deletions lib/build/otp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,20 @@ export interface SharedSmsResult {
* credential ever existed). Builder's own Railway service now holds a
* direct Twilio credential (TWILIO_ACCOUNT_SID/TWILIO_AUTH_TOKEN), copied
* from core's real, working Twilio account on 2026-10-05, and
* TWILIO_OTP_FROM_NUMBER is the real, confirmed-live ZeroVoice number
* (+19377642838) already wired for two-way SMS. Explicit From/To (never
* routed through a Messaging Service's number-selection) — using a
* MessagingServiceSid here produced a confusing same-number From/To
* collision during live testing earlier this session.
* TWILIO_OTP_FROM_NUMBER is a Builder-owned number (+19377642838) already
* wired for two-way SMS. Explicit From/To (never routed through a
* Messaging Service's number-selection) — using a MessagingServiceSid here
* produced a confusing same-number From/To collision during live testing
* earlier this session.
*
* #944 follow-up (2026-10-07): this number's live A2P 10DLC campaign was
* registered under ZeroVoice's branding/use-case (CUSTOMER_CARE, message
* samples referencing ZeroVoice by name), not Builder's — which is why
* carriers are currently blocking sends (core#8533, error 30034/30896).
* A second Builder-owned number (+18313183353) has the same problem. Both
* need their own 2FA-use-case campaigns resubmitted under Builder's own
* branding/URL, with no ZeroVoice references — tracked in core#8533, a
* Twilio-console task, not a code change.
*/
export async function sendSharedSms(toE164Number: string, body: string): Promise<SharedSmsResult> {
const accountSid = process.env.TWILIO_ACCOUNT_SID || ''
Expand Down
Loading