Repository navigation
feat(auth): SMS opt-in disclosure for phone-first form (#944, A2P campaign alignment) - #1007
Merged
Merged
Conversation
added 2 commits
October 6, 2026 22:59
…one field Supports the Twilio A2P 10DLC campaign resubmission (core#8533) as a 2FA/ verification use case — carriers require the opt-in language shown to the user at the point of consent to match what's documented in the campaign registration. This is that language, placed directly under the phone input it describes.
…r, not ZeroVoice's Mislabeled during #938's implementation. Both Builder-owned OTP numbers (937, 831) are currently carrier-blocked because their live A2P 10DLC campaigns were registered under ZeroVoice's branding/use case (CUSTOMER_CARE) instead of Builder's — tracked in core#8533.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the SMS opt-in disclosure line under the phone-first signup form's phone field: "We'll text you a one-time code to verify this number."
This was cited as already-live product copy in the A2P 10DLC 2FA campaign just resubmitted to Twilio (core#8533) — it needs to be real before the campaign's message-flow description is accurate. Also corrects a misleading doc comment in lib/build/otp.ts that called the +19377642838 number "the ZeroVoice number" (it's Builder's own; the carrier-rejection confusion traced back in part to this number/campaign being registered under ZeroVoice's branding instead of Builder's).
No test changes needed — pure copy addition, covered by existing Auth phone-form tests (36/36 pass). tsc clean.