Skip to content

Only publish on new tags - #29

Merged
fibbo merged 1 commit into
mainfrom
fibbo/only-deploy-image-when-essential-files-change
Sep 3, 2026
Merged

fibbo merged 1 commit into
mainfrom
fibbo/only-deploy-image-when-essential-files-change

Conversation

@fibbo

@fibbo fibbo commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

We shouldn't create and deploy docker images on unrelated changes.

@fibbo
fibbo requested review from aaronk-zhinst and a lite review from Copilot September 1, 2026 13:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflows so Docker images are only published when a new version tag is pushed, while keeping PR builds limited to Docker-relevant changes.

Changes:

  • Restrict the PR build workflow to run only when Docker build inputs (Dockerfile/scripts/version/workflow) change.
  • Change the DockerHub deploy workflow trigger from push on main to push on version tags (v*).
  • Add a guard step that validates the pushed tag (vX.Y.Z...) matches labone_version.txt before building/pushing images.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/build_dockerfile.yml Adds paths filtering to avoid running PR image builds for unrelated changes.
.github/workflows/build_and_deploy_dockerhub.yml Deploys only on v* tags and enforces tag/version consistency before pushing images.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@fibbo
fibbo merged commit 836bbcf into main Sep 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants