Skip to content

chore: pin core 2.4.0, engine and monitor 0.46.0, worker 0.5.0 and web client 6.1.0 - #43

Merged
leandrolerena merged 19 commits into
developfrom
feature/network-zones-02-pins
Nov 8, 2026
Merged

leandrolerena merged 19 commits into
developfrom
feature/network-zones-02-pins

Conversation

@leandrolerena

@leandrolerena leandrolerena commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Description

Pins, in compose.yaml:10-14:

Image Before After
core 2.3.0 2.4.0
engine 0.44.1 0.46.0
monitor 0.44.1 0.46.0
worker 0.3.0 0.5.0
web 6.0.1 6.1.0

They move together: core holds the zones, the engine routes by zone and accepts only 0.46 clients, worker 0.5 reads NEOPS_WORKER_NETWORK_ZONES, and web 6.1 ships the Network zones page the docs send operators to.

cms-init now seeds the admin role with core 2.4.0's manage.py bootstrap_admin_role (core 05 zebbra/neops-core#2469), which also grants write on network-zones, and cms/bootstrap_admin_role.py is gone. The grants re-apply on every ./neops up. When the command exits 3 (a role other users hold), cms-init prints a notice, skips grant_workflow_permissions and carries on.

The docs say that a role other users already hold (every user with the admin client role, under OIDC) gets the network-zones write from core 2.4.0's seed (zebbra/neops-core#2474) but not the workflow profile, which cms-init skips on exit 3 (docs/10-install.md, docs/35-network-zones.md). docs/30-operations.md gains "Upgrading to engine 0.46" (let every run finish, then git pull && ./neops up) and, under "Going back", the 2.4.0 step that drains core's log outbox first; docs/35-network-zones.md points to core's 2.4.0 notes for the zones going back deletes.

With cms/ gone from the repository root, ruff no longer counts the e2e helper tests/e2e/cms.py as first-party, so three e2e import blocks are re-sorted (style commit).

Look at first

The upgrade these pins trigger: core 2.4.0 changes the network index mapping, so ./neops up rebuilds that index; engine 0.46.0's migration recreates the claim index without CONCURRENTLY.

Deviations from the design

None.

Testing

Manual lab integration run zones-it, twice on 2026-10-31:

  • round 1, before the review fixes: core 75cf9bf57, engine 029e791e, SDK 725b28b, web a26da57;
  • round 2, after every review fix: core 839a61400, engine 50dc36d9, SDK cc98ac9, web ebf30ad, lab 2636d6a. The final heads differ only by one engine code comment and doc line, and the SDK's unit-tested formatter for list messages.

No lab round exercised this PR: compose was not part of them, and the pinned images don't exist yet.

The engine rows 14–20, the SDK rows 21–23 and the lab row 33 were re-cut on 2026-11-06: engine zebbra/neops-workflow-engine#513 to zebbra/neops-workflow-engine#526 (plus zebbra/neops-workflow-engine#512 for the Remediation fix), SDK zebbra/neops-worker-sdk-py#326 to zebbra/neops-worker-sdk-py#331 (plus zebbra/neops-worker-sdk-py#324 and zebbra/neops-worker-sdk-py#325), lab zebbra/neops-lab#52 to zebbra/neops-lab#54. The table below still names the originals.

Network Zones train, in merge order
# PR Branch Step Then
1 neops-workflow-engine, no PR 0 done: the user tagged engine v0.45.0 from develop
2 zebbra/neops-worker-sdk-py#318 neops-worker-sdk-py fix/pin-engine-client-0.45.0 0 merged 2026-11-04 (f7cdf41, client ==0.45.0); SDK v0.4.0 is tagged on it and released (2026-11-06); Claude has merged it into SDK 01–03
3 zebbra/neops-core#2467 neops-core fix/pyasn1-0.6.5 1 merged 2026-11-02
4 zebbra/neops-core#2464 neops-core feature/network-zones-01-model 1 merged
5 zebbra/neops-core#2465 neops-core feature/network-zones-02-run-writes 1 merged
6 zebbra/neops-core#2466 neops-core feature/network-zones-03-search-and-lock 1 merged
7 zebbra/neops-core#2468 neops-core feature/network-zones-04-zone-paging-and-sort 1 merged
8 zebbra/neops-core#2469 neops-core feature/network-zones-05-chart-admin-role 1 merged 2026-11-05; v2.4.0-beta.1 is tagged on its tip (d2b030b19)
9 zebbra/neops-core#2473 neops-core feature/network-zones-06-unlock-write-refused 1 merged 2026-11-05; v2.4.0-beta.2 is tagged on its tip (da4974bb6): the unlock answers WRITE_REFUSED, which engine 04 needs
10 zebbra/neops-workflow-engine#497 neops-workflow-engine feature/network-zones-01-nest-client-2.3.0 2 merged 2026-11-02
11 zebbra/neops-workflow-engine#506 neops-workflow-engine fix/postgres-user 2 merged 2026-11-02, after v0.45.0-beta.1; v0.45.0 is the first release that holds it
12 zebbra/neops-workflow-engine#498 neops-workflow-engine feature/network-zones-02-definitions 2 merged 2026-11-04
13 zebbra/neops-workflow-engine#499 neops-workflow-engine feature/network-zones-03-routing 2 merged 2026-11-04
14 zebbra/neops-workflow-engine#500 neops-workflow-engine feature/network-zones-04-device-writes 2 after core 06, the user merges 04–10 back to back
15 zebbra/neops-workflow-engine#501 neops-workflow-engine feature/network-zones-05-prerelease-versions 2
16 zebbra/neops-workflow-engine#502 neops-workflow-engine feature/network-zones-06-refuse-invalid-pushes 2
17 zebbra/neops-workflow-engine#503 neops-workflow-engine feature/network-zones-07-cms-request-timeout 2
18 zebbra/neops-workflow-engine#504 neops-workflow-engine feature/network-zones-08-never-polled-and-log-context 2
19 zebbra/neops-workflow-engine#505 neops-workflow-engine feature/network-zones-09-monitor-context 2
20 zebbra/neops-workflow-engine#510 neops-workflow-engine feature/network-zones-10-cms-at-lock-and-write-back 2 v0.46.0-beta.3 is tagged on its tip (4c4f2f7c) and published client 0.46.0b3; the engine accepts the SDK's 0.46.0b2
21 zebbra/neops-worker-sdk-py#313 neops-worker-sdk-py feature/network-zones-01-job-meta 3 SDK v0.4.0 is released; the user merges 01–03 back to back
22 zebbra/neops-worker-sdk-py#314 neops-worker-sdk-py feature/network-zones-02-zones 3
23 zebbra/neops-worker-sdk-py#315 neops-worker-sdk-py feature/network-zones-03-strict-compatibility 3 v0.5.0-beta.2 is tagged on its tip (907d443), on client 0.46.0b2
24 zebbra/neops-web-client#183 neops-web-client feature/network-zones-01-angular-client-2.3.0 4 merged 2026-11-02
25 zebbra/neops-web-client#184 neops-web-client feature/network-zones-02-zones 4 merged 2026-11-05; v6.1.0-beta.1 is tagged on its tip (953db30)
26 zebbra/neops-worker-boilerplate#5 neops-worker-boilerplate feature/network-zones-01-sdk-0.4 5 merged 2026-11-03 at its earlier head: develop pins SDK ==0.4.0b1
27 zebbra/neops-worker-boilerplate#6 neops-worker-boilerplate fix/network-zones-sdk-0.5.0b1-pin 5 SDK ==0.5.0b2, uv lock; the user merges it
28 neops-core, no PR 6 after the beta soak, the user tags core v2.4.0
29 not opened yet neops-workflow-engine re-pin PR, not opened yet 7 nest 2.4.0, MINIMUM_CORE_VERSION 2.4.0, generated paged networkZones, then tag engine v0.46.0
30 not opened yet neops-worker-sdk-py re-pin PR, not opened yet 8 client ==0.46.0, then tag SDK v0.5.0
31 not opened yet neops-worker-boilerplate re-pin PR, not opened yet 9 SDK ==0.5.0
32 not opened yet neops-web-client re-pin PR, not opened yet 10 angular 2.4.0 exactly, library peer floor back to >=2.4.0 <3, plain npm install, re-render docs/dashboard-cards/table.md against core v2.4.0, then tag web v6.1.0
33 zebbra/neops-lab#50 neops-lab feature/network-zones-01-scenario 11 once every final exists
34 #42 neops-docker-compose feature/network-zones-01-central-worker-zone 11 once every final exists
35 this PR neops-docker-compose feature/network-zones-02-pins 11
36 zebbra/neops-helm#27 neops-helm feature/network-zones-01-central-worker-zone 11 once every final exists

Phase A (steps 1–5) ships the zones betas: Claude tags each on the tip of its stack once CI is green, and nothing merges into develop for a beta. Claude keeps every zones branch current by merging develop in. Merges into develop or main, step 0 (closing the 0.45 line from develop before engine 02 or SDK 01 merges) and every final tag are the user's. Phase B (6–10) ships the finals, and Phase C (11) the deployments that pin them.

Checklist:

  • PR label has been set
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Network zones need the three together: core holds the zones, the engine
routes jobs by zone and refuses an unzoned worker once a zone exists, and
worker 0.4 reads NEOPS_WORKER_NETWORK_ZONES. Engine 0.45 accepts only 0.45
clients, so the worker cannot stay on 0.3.
Its Network zones page is where docs/35-network-zones.md tells operators
to create a zone. Like the other pins on this branch, it waits on a tag
that is not out yet: core v2.4.0, engine v0.45.0, SDK v0.4.0 and web
client v6.1.0.
Core 2.4.0 owns the seed as a management command, so compose and the
Helm chart give the admin the same grants. It adds write on
network-zones, so the admin can create a zone right after install.
cms/bootstrap_admin_role.py and its mount are gone.
The engine is about to honour POSTGRES_USER (default postgres); its
database stays neops-workflow. The comment now holds before and after.
The command came with core 2.4.0. An emergency NEOPS_CORE_TAG below that
failed cms-init with Unknown command, and every core service waits on
cms-init. cms-init now skips the seed with a notice, the way it already
skips grant_workflow_permissions.
bootstrap_admin_role now leaves a role other users hold alone and exits
3. cms-init takes 3 as a warning and skips grant_workflow_permissions,
which would widen that role for every holder; any other failure still
fails cms-init. The tests run cms-init's script against a stub python.
With cms/ gone from the repository root, ruff no longer counts the e2e
helper cms.py as first-party.
Engine 0.45.0 and worker 0.4.0 are released from develop without network
zones, so the zones release is engine 0.46.0 and worker 0.5.0. Engine 0.46
accepts only 0.46 clients.
@leandrolerena leandrolerena changed the title chore: pin core 2.4.0, engine and monitor 0.45.0, worker 0.4.0 and web client 6.1.0 chore: pin core 2.4.0, engine and monitor 0.46.0, worker 0.5.0 and web client 6.1.0 Nov 3, 2026
Going back restores a dump without core_logoutboxentry, so lines the log store
has not taken yet are lost; the 2.3.0 steps apply only when going back past it.
bootstrap_admin_role leaves a role other users hold alone and exits 3, so on an
OIDC install, or one with colleagues added to the role, the zones write never
arrives; the notice is only in cms-init's log.
…om chaos_logs

cms/ is gone, so the config gate's linked directories must not name it, and the
chaos scenarios run against whichever engine compose.yaml pins.
Let every run finish, then git pull && ./neops up; up starts core before the
engine, and workers outside compose move to the pinned image.
Point to core's 2.4.0 notes, which hold the rule and the way forward again.
compose pins core 2.4.0, which has the command; a core below that is not
supported here, so cms-init no longer skips the seed for it.
core 2.4.0's bootstrap_admin_role gives the role it seeds the network-zones
write also when other users hold it (zebbra/neops-core#2474); cms-init still
skips the workflow profile on its exit 3.
Every holder of the shared role, so under OIDC every user the identity provider
puts in it, may write every zone; the seed re-applies the write on every up.
Base automatically changed from feature/network-zones-01-central-worker-zone to develop November 7, 2026 15:46
@leandrolerena
leandrolerena merged commit 6702ea4 into develop Nov 8, 2026
3 checks passed
@leandrolerena
leandrolerena deleted the feature/network-zones-02-pins branch November 8, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-other PR does something not covered by other labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant