Repository navigation
chore: pin core 2.4.0, engine and monitor 0.46.0, worker 0.5.0 and web client 6.1.0 - #43
Merged
Merged
Conversation
Network zones need the three together: core holds the zones, the engine routes jobs by zone and refuses an unzoned worker once a zone exists, and worker 0.4 reads NEOPS_WORKER_NETWORK_ZONES. Engine 0.45 accepts only 0.45 clients, so the worker cannot stay on 0.3.
Its Network zones page is where docs/35-network-zones.md tells operators to create a zone. Like the other pins on this branch, it waits on a tag that is not out yet: core v2.4.0, engine v0.45.0, SDK v0.4.0 and web client v6.1.0.
This was referenced Oct 31, 2026
Core 2.4.0 owns the seed as a management command, so compose and the Helm chart give the admin the same grants. It adds write on network-zones, so the admin can create a zone right after install. cms/bootstrap_admin_role.py and its mount are gone.
The engine is about to honour POSTGRES_USER (default postgres); its database stays neops-workflow. The comment now holds before and after.
The command came with core 2.4.0. An emergency NEOPS_CORE_TAG below that failed cms-init with Unknown command, and every core service waits on cms-init. cms-init now skips the seed with a notice, the way it already skips grant_workflow_permissions.
bootstrap_admin_role now leaves a role other users hold alone and exits 3. cms-init takes 3 as a warning and skips grant_workflow_permissions, which would widen that role for every holder; any other failure still fails cms-init. The tests run cms-init's script against a stub python.
With cms/ gone from the repository root, ruff no longer counts the e2e helper cms.py as first-party.
Engine 0.45.0 and worker 0.4.0 are released from develop without network zones, so the zones release is engine 0.46.0 and worker 0.5.0. Engine 0.46 accepts only 0.46 clients.
2 of 4 tasks
Going back restores a dump without core_logoutboxentry, so lines the log store has not taken yet are lost; the 2.3.0 steps apply only when going back past it.
bootstrap_admin_role leaves a role other users hold alone and exits 3, so on an OIDC install, or one with colleagues added to the role, the zones write never arrives; the notice is only in cms-init's log.
…om chaos_logs cms/ is gone, so the config gate's linked directories must not name it, and the chaos scenarios run against whichever engine compose.yaml pins.
Let every run finish, then git pull && ./neops up; up starts core before the engine, and workers outside compose move to the pinned image.
Point to core's 2.4.0 notes, which hold the rule and the way forward again.
compose pins core 2.4.0, which has the command; a core below that is not supported here, so cms-init no longer skips the seed for it.
core 2.4.0's bootstrap_admin_role gives the role it seeds the network-zones write also when other users hold it (zebbra/neops-core#2474); cms-init still skips the workflow profile on its exit 3.
Every holder of the shared role, so under OIDC every user the identity provider puts in it, may write every zone; the seed re-applies the write on every up.
Base automatically changed from
feature/network-zones-01-central-worker-zone
to
develop
November 7, 2026 15:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v2.4.0, enginev0.46.0(engine and monitor images), SDKv0.5.0and web clientv6.1.0; core'sv2.4.0must carry zebbra/neops-core#2477 (docs/going-back-network-zones), since the docs link its "Going back below 2.4.0" headingdevelopmust keep working throughgit pull && ./neops upPins, in
compose.yaml:10-14:They move together: core holds the zones, the engine routes by zone and accepts only 0.46 clients, worker 0.5 reads
NEOPS_WORKER_NETWORK_ZONES, and web 6.1 ships the Network zones page the docs send operators to.cms-initnow seeds the admin role with core 2.4.0'smanage.py bootstrap_admin_role(core 05 zebbra/neops-core#2469), which also grants write onnetwork-zones, andcms/bootstrap_admin_role.pyis gone. The grants re-apply on every./neops up. When the command exits 3 (a role other users hold),cms-initprints a notice, skipsgrant_workflow_permissionsand carries on.The docs say that a role other users already hold (every user with the
adminclient role, under OIDC) gets thenetwork-zoneswrite from core 2.4.0's seed (zebbra/neops-core#2474) but not the workflow profile, whichcms-initskips on exit 3 (docs/10-install.md,docs/35-network-zones.md).docs/30-operations.mdgains "Upgrading to engine 0.46" (let every run finish, thengit pull && ./neops up) and, under "Going back", the 2.4.0 step that drains core's log outbox first;docs/35-network-zones.mdpoints to core's 2.4.0 notes for the zones going back deletes.With
cms/gone from the repository root, ruff no longer counts the e2e helpertests/e2e/cms.pyas first-party, so three e2e import blocks are re-sorted (stylecommit).Look at first
The upgrade these pins trigger: core 2.4.0 changes the network index mapping, so
./neops uprebuilds that index; engine 0.46.0's migration recreates the claim index withoutCONCURRENTLY.Deviations from the design
None.
Testing
Manual lab integration run
zones-it, twice on 2026-10-31:75cf9bf57, engine029e791e, SDK725b28b, weba26da57;839a61400, engine50dc36d9, SDKcc98ac9, webebf30ad, lab2636d6a. The final heads differ only by one engine code comment and doc line, and the SDK's unit-tested formatter for list messages.No lab round exercised this PR: compose was not part of them, and the pinned images don't exist yet.
The engine rows 14–20, the SDK rows 21–23 and the lab row 33 were re-cut on 2026-11-06: engine zebbra/neops-workflow-engine#513 to zebbra/neops-workflow-engine#526 (plus zebbra/neops-workflow-engine#512 for the Remediation fix), SDK zebbra/neops-worker-sdk-py#326 to zebbra/neops-worker-sdk-py#331 (plus zebbra/neops-worker-sdk-py#324 and zebbra/neops-worker-sdk-py#325), lab zebbra/neops-lab#52 to zebbra/neops-lab#54. The table below still names the originals.
Network Zones train, in merge order
v0.45.0fromdevelopfix/pin-engine-client-0.45.0f7cdf41, client==0.45.0); SDKv0.4.0is tagged on it and released (2026-11-06); Claude has merged it into SDK 01–03fix/pyasn1-0.6.5feature/network-zones-01-modelfeature/network-zones-02-run-writesfeature/network-zones-03-search-and-lockfeature/network-zones-04-zone-paging-and-sortfeature/network-zones-05-chart-admin-rolev2.4.0-beta.1is tagged on its tip (d2b030b19)feature/network-zones-06-unlock-write-refusedv2.4.0-beta.2is tagged on its tip (da4974bb6): the unlock answersWRITE_REFUSED, which engine 04 needsfeature/network-zones-01-nest-client-2.3.0fix/postgres-userv0.45.0-beta.1;v0.45.0is the first release that holds itfeature/network-zones-02-definitionsfeature/network-zones-03-routingfeature/network-zones-04-device-writesfeature/network-zones-05-prerelease-versionsfeature/network-zones-06-refuse-invalid-pushesfeature/network-zones-07-cms-request-timeoutfeature/network-zones-08-never-polled-and-log-contextfeature/network-zones-09-monitor-contextfeature/network-zones-10-cms-at-lock-and-write-backv0.46.0-beta.3is tagged on its tip (4c4f2f7c) and published client 0.46.0b3; the engine accepts the SDK's 0.46.0b2feature/network-zones-01-job-metav0.4.0is released; the user merges 01–03 back to backfeature/network-zones-02-zonesfeature/network-zones-03-strict-compatibilityv0.5.0-beta.2is tagged on its tip (907d443), on client 0.46.0b2feature/network-zones-01-angular-client-2.3.0feature/network-zones-02-zonesv6.1.0-beta.1is tagged on its tip (953db30)feature/network-zones-01-sdk-0.4developpins SDK==0.4.0b1fix/network-zones-sdk-0.5.0b1-pin==0.5.0b2,uv lock; the user merges itv2.4.0MINIMUM_CORE_VERSION2.4.0, generated pagednetworkZones, then tag enginev0.46.0==0.46.0, then tag SDKv0.5.0==0.5.02.4.0exactly, library peer floor back to>=2.4.0 <3, plainnpm install, re-renderdocs/dashboard-cards/table.mdagainst corev2.4.0, then tag webv6.1.0feature/network-zones-01-scenariofeature/network-zones-01-central-worker-zonefeature/network-zones-02-pinsfeature/network-zones-01-central-worker-zonePhase A (steps 1–5) ships the zones betas: Claude tags each on the tip of its stack once CI is green, and nothing merges into
developfor a beta. Claude keeps every zones branch current by mergingdevelopin. Merges intodevelopormain, step 0 (closing the 0.45 line fromdevelopbefore engine 02 or SDK 01 merges) and every final tag are the user's. Phase B (6–10) ships the finals, and Phase C (11) the deployments that pin them.Checklist: