Conversation
|
I opened a PR on Blueprint to solve types deprecation warnings: https://redirect.github.com/palantir/blueprint/pull/7839 |
Deploying react-science with
|
| Latest commit: |
c50bbab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e5e67fb.react-science.pages.dev |
| Branch Preview URL: | https://react-19.react-science.pages.dev |
Closes: #922 BREAKING-CHANGE: `react-science` now requires React 19. All peer dependencies have been updated to the latest version. If you use `Popover` or `Overlay` from Blueprint, or `popoverProps` from our components that expose it, follow the Blueprint migration guide. React migration guide: https://react.dev/blog/2024/04/25/react-19-upgrade-guide Blueprint migration guide: https://github.com/palantir/blueprint/wiki/React-19-Support Popper migration guide: https://floating-ui.com/docs/migration
|
@stropitek After at least two hours trying to fix your workarounds, I give up. I hope you'll have an idea to clean this up. Here are the problematic lines: react-science/src/components/toolbar/Toolbar.tsx Lines 282 to 286 in 1084a45 react-science/src/components/button/Button.tsx Lines 83 to 94 in 1084a45 |
|
I don't have a clean fix, but I have another workaround which consists of using I'm pushing the commit and try to figure something better out, but I'm not very confident about it... I noticed a small regression compared to https://react-science.pages.dev/. CleanShot.2026-06-10.at.14.15.39.mp4 |
|
I simplified the implementation, but the principle is the same and I don't see a better way to do it.
This might be related to We can:
|
Did not notice this. I will check what I can do. |
|
My latest commit should make buttons pretty consistent with what it was before. BP has changed the horizontal padding values from 10px to 8px so it's normal that they are less wide now. I noticed something else while testing: the compact prop passed to toolbar tooltips does not seem to have any effect anymore. https://react-19.react-science.pages.dev/stories/?path=/story/components-toolbar--custom-tooltip-content Before it did not have space in between the toolbar button and the tooltip content. |
|
Thanks for the fix. I'm now reviewing the stories one-by-one |
|
I noticed that the buttons became more rounded and smaller. I guess that's OK but I wonder why. Edit: this seems to be a more general change. many form components are now a bit smaller and rounder. |
|
I pushed a couple fixes. It now LGTM |
Yes they changed many things. Colors are also not the same. They also use variables now for things like margins and spacing so it's not surprising if things shift a bit. |
Uh oh!
There was an error while loading. Please reload this page.