Skip to content

fix(trunk): let callers own concurrency#436

Merged
ss-o merged 1 commit into
mainfrom
bug-408-remove-reusable-concurrency
Jun 1, 2026
Merged

fix(trunk): let callers own concurrency#436
ss-o merged 1 commit into
mainfrom
bug-408-remove-reusable-concurrency

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented Jun 1, 2026

Summary

  • remove top-level concurrency from the reusable Trunk workflow
  • keep concurrency on each push/PR caller

Evidence

After #434, callers resolved the repaired reusable workflow but still failed before job creation. The called workflow reused the caller's ${{ github.workflow }}-${{ github.ref }} group with cancel-in-progress: true, cancelling the invoking run.

Verification

  • YAML parse with Ruby Psych
  • git diff --check
  • workspace audit confirms active callers retain concurrency

Tracks #408.

@ss-o ss-o marked this pull request as ready for review June 1, 2026 07:20
@ss-o ss-o requested a review from a team as a code owner June 1, 2026 07:20
Copilot AI review requested due to automatic review settings June 1, 2026 07:20
@ss-o ss-o merged commit df7c51b into main Jun 1, 2026
2 checks passed
@ss-o ss-o deleted the bug-408-remove-reusable-concurrency branch June 1, 2026 07:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the GitHub Actions workflow configuration for “Trunk Code Quality” by removing the workflow-level concurrency controls.

Changes:

  • Removed the concurrency block that grouped runs by workflow + ref and canceled in-progress runs.

Comment on lines 1 to 6
---
name: Trunk Code Quality

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

on:
workflow_call:
secrets:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants