fix: make searchKnn memory-safe and exception-safe#363
Closed
andreinknv wants to merge 1 commit into
Closed
Conversation
searchKnn (both classes) had two defects around its optional filter
functor and the call into hnswlib:
- The CustomFilterFunctor was heap-allocated with new and freed only
on the success path. The early error returns — array-length
mismatch and k out of range — leaked it.
- The call into hnswlib's searchKnn was unguarded. hnswlib throws
std::runtime_error ("cand error") on a corrupt graph; the
exception escaped the N-API method and aborted the process. Every
other hnswlib call site here is already guarded.
Hold the functor in a std::unique_ptr so it is released on every
exit path, and wrap the search call so a hnswlib exception surfaces
as a thrown JavaScript Error.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
searchKnn(bothBruteforceSearchandHierarchicalNSW) had twodefects:
CustomFilterFunctoris allocated withnewand freed only on the success path. The early error returns —array-length mismatch and
kout of range — return without deletingit, leaking the functor on every rejected call that supplied a filter.
searchKnnis not wrappedin
try/catch. hnswlib throwsstd::runtime_error("cand error")on a corrupt graph; the exception escapes the N-API method and aborts
the process. Every other hnswlib call site in this file is already
guarded.
Fix
Hold the functor in a
std::unique_ptrso it is released on every exitpath, and wrap the
searchKnncall so a hnswlib exception surfaces as athrown JavaScript
Error.Verification
npm test— 100/100 passing; native addon builds clean.🤖 Generated with Claude Code