fix: prevent dangling index_ after a failed index load#362
Closed
andreinknv wants to merge 1 commit into
Closed
Conversation
readIndexSync (both classes) and the async Load*IndexWorker::Execute methods deleted the existing index_ before constructing its replacement. When the constructor threw — corrupt or unreadable file — index_ was left pointing at freed memory: a use-after-free on the next method call and a double-free in the destructor. Construct the replacement into a local first; delete the old index and reassign only after construction succeeds. On failure index_ keeps its previous valid value. Mirrors the pattern initIndex already uses. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
readIndexSync(bothBruteforceSearchandHierarchicalNSW) and theasynchronous
Load*IndexWorker::Executemethods delete the existingindex_before constructing its replacement:If that constructor throws — a corrupt or unreadable index file —
index_is left pointing at freed memory. The next method call on theinstance is a use-after-free, and the destructor later runs
delete index_a second time (double-free).Fix
Construct the replacement into a local pointer first; delete the old
index and reassign only after construction succeeds. On failure
index_keeps its previous valid value. This mirrors the pattern
initIndexalready uses.
Verification
npm test— 100/100 passing; native addon builds clean.🤖 Generated with Claude Code