Skip to content

XDOCKER-87: Automatically build SOLR docker image with compose#22

Open
ASHISH932 wants to merge 4 commits into
xwiki:masterfrom
ASHISH932:solr
Open

XDOCKER-87: Automatically build SOLR docker image with compose#22
ASHISH932 wants to merge 4 commits into
xwiki:masterfrom
ASHISH932:solr

Conversation

@ASHISH932

Copy link
Copy Markdown
Contributor

No description provided.

* Created solr docker image template
* Edited build.gradle to use solr template
@ASHISH932

Copy link
Copy Markdown
Contributor Author

FTR:
build.gradle
template/solr/Dockerfile
template/solr/docker-compose.yml
template/solr/solr-init.sh (same as in contrib/solr)

@vmassol vmassol self-assigned this Jul 9, 2019
@vmassol

vmassol commented Aug 1, 2019

Copy link
Copy Markdown
Member

Note: this PR supersedes #14

@vmassol

vmassol commented Aug 1, 2019

Copy link
Copy Markdown
Member

This PR was discussed on matrix (https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1564651451225975nhSFW:matrix.org?via=matrix.xwiki.com&via=matrix.org&via=matrix.wina.be). The conclusion is:

  • We don't need a custom SOLR image for XWiki. We should use the official SOLR image and configure it for XWiki using a compose file for example.
  • However, it's interesting to have a example of such a compose file in the github repo and in the doc
  • It's also interesting to make the xwiki image easily configurable to use an external solr instance (by exposing a "docker run" command line parameter for that).

Thanks @ASHISH932 !

@vmassol

vmassol commented Sep 10, 2019

Copy link
Copy Markdown
Member

ping @ASHISH932 about my last comment. Are you active on this PR? What's your plan? Thx!

@ASHISH932

Copy link
Copy Markdown
Contributor Author

Currently, I'm not working on this PR but would possibly update it later. Since our conclusion is to create a docker-compose file only, so the changes would happen in README file only. So if you want to close the PR, for now, you could.

@vmassol

vmassol commented Sep 11, 2019

Copy link
Copy Markdown
Member

I don't think the change is only a README change. See above where I mentioned:

It's also interesting to make the xwiki image easily configurable to use an external solr instance (by exposing a "docker run" command line parameter for that).

Otherwise how do you set it in a compose file?

@ASHISH932

Copy link
Copy Markdown
Contributor Author

This parameter is already exposed. We can use external solr with our container
https://github.com/xwiki-contrib/docker-xwiki/blob/master/README.md#using-an-external-solr-service

Is that what you mean ?

@vmassol

vmassol commented Sep 11, 2019

Copy link
Copy Markdown
Member

This parameter is already exposed. We can use external solr with our container
https://github.com/xwiki-contrib/docker-xwiki/blob/master/README.md#using-an-external-solr-service

Is that what you mean ?

Indeed, I guess it was done in a different PR.

Note: The doc doesn't explain how the solr.remote property is set so that could be improved in the doc but it's minor.

So I agree it's only doc that's remaining.

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants