WIP: Paper deprecation fix - #13
Closed
bhabanip07 wants to merge 67 commits into
Closed
bhabanip07 wants to merge 67 commits into
bhabanip07 wants to merge 67 commits into
Conversation
…#962) * Add failing tests for tile order and length changes * Expose didUpdate callback on grid-list update * remove layout-padding remnant * Sort tiles by dom order on grid-list didUpdate * Add tests for basic grid-list attributes
1. For paper-input, validate only when its value changes. 2. For paper-autocomplete, validate only when selection is changed.
Hi, I saw that this issue adopted-ember-addons#791 hasn't been fixed yet. Here's a PR to fix it. I've added a test and an example of a disabled tab in the dummy app.
Deprecations Added in 3.4 Use closure actions instead of `sendAction` https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action
…le render (adopted-ember-addons#980) Im getting this error `Assertion Failed: You modified "canPageBack" twice in a single render` in mobile chrome which prevents the smoothly transition to hidden tabs. I tracked it down to `this.fixOffsetIfNeeded();` which is executed everytime the `_selectedTab` change which at least in my use case, it can be changed both programatically (i.e `selected=someProperty`) or by the end user when clicked on a tab or the next, previous arrows.
…ed-ember-addons#794) In the angular implementation, they allow you to customize the button by using a ["highlightClass"](https://github.com/angular/material/blob/v1.1.4/src/components/toast/toast.js#L174): > If set, the given class will be applied to the highlighted action button.<br/> > This allows you to specify the highlight color easily. Highlight classes are `md-primary`, `md-warn` and `md-accent
Owner
|
This is looking strange I've updated ember-paper.beta-9 on |
Author
|
closing this and making this into new PR-- #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.