Map MSSQL uniqueidentifier to google/uuid#436
Open
rosensama wants to merge 1 commit into
Open
Conversation
Previously fell through to schemaType, producing a bogus `Uniqueidentifier` struct name. Map to uuid.UUID / uuid.NullUUID to mirror the postgres uuid mapping and reuse the existing --uuid flag and import wiring. mssql.UniqueIdentifier (github.com/microsoft/go-mssqldb) was an alternative, but we preferred not to introduce a new dependency when google/uuid was already available from the postgres path. Refs xo#435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniqueidentifiercolumns previously fell throughSqlserverGoTypetoschemaType, generating a placeholderUniqueidentifierstruct name in user code.uuid.UUID/uuid.NullUUID, mirroring the postgresuuidmapping atloader/postgres.go:165and reusing the existing--uuidflag and import wiring (templates/go/go.go:143,:2194,:2034).mssql.UniqueIdentifier(fromgithub.com/microsoft/go-mssqldb) was considered but rejected to avoid introducing a new dependency whengoogle/uuidis already available from the postgres path.Fixes #435.
Tested against an MSSQL repro of the issue with a local build.
🤖 Generated with Claude Code