Support checksum instead of mtime for index file comparison - #175
Open
nteodosio wants to merge 4 commits into
Open
Support checksum instead of mtime for index file comparison#175nteodosio wants to merge 4 commits into
nteodosio wants to merge 4 commits into
Conversation
Contributor
Author
|
This has been running reliably in our staging infrastructure for a couple of days. Here one log with the debug statements. |
nteodosio
marked this pull request as ready for review
July 2, 2026 13:59
Owner
|
Hi! I am currently on vacation and will properly review this later (11+ days), but one immediate thing: Can we use Blake3 for hashing, or a CRC-style checksum like XXH3 if that is sufficient? Then we don't gain an additional dependency, because appstream-compose already depends on blake3 (unless disabled). |
Contributor
Author
|
Hi, I conflated Blake with Black and thought it was for linting. (:
Blake will surely do, I will update the merge request.
Have a nice vacation!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This originates from a Launchpad request.
Mtime comparison causes a self-sustaining chain: Launchpad publisher publishes index files <-> Appstream generates new files (even if index file didn't change).