Repository navigation
Conversation
…eact #4620) Companion branch to xh/hoist-react#4636 - exercises CubeFieldSpec.calculatedFn in the cube test panel: - pctCommission is now a calculated field computing percent-of-total at read time from the row's SUM-aggregated commission and a per-update total memoized in ctx.appData via ctx.filteredRecords. PctTotalAggregator deleted. - No pctCommission values stamped on source orders in load or update streams - calculated fields need no source data, and the View retains its incremental data-only update path with the field included. - Column marked read-only (editing a calculated field throws), and the field drops out of the query in the non-projection A/B mode, which calculated views disallow. Note: requires a local hoist-react checkout on the eponymous branch.
Hoist now renders columns bound to calculated fields read-only automatically (hoist-react #4620).
Connected stores are now always projections - the View enforces the mode itself, so the tester exercises the enforced default with no explicit config.
6 tasks done
Member
Author
|
Superseded by a follow-up PR from branch claude/issue-4637-kyt4eq, which contains this branch's full history plus the StoreConfig.view API updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to xh/hoist-react#4636 (eponymous branch) - exercises
CubeFieldSpec.calculatedFnin the cube test panel, per the validation plan in hoist-react #4620.Run against a local hoist-react checkout on
claude/issue-4620-kyt4eq.Changes
pctCommissionis now a calculated field: percent-of-total computed lazily at read time from the row's SUM-aggregatedcommissionand a per-update total memoized inctx.appDataviactx.filteredRecords.PctTotalAggregatordeleted.pctCommissionvalues are stamped on source orders in the load or update streams - calculated fields require no source data.editable: false(calculated fields are read-only), toggle relabeledPct Total (calc)?, and the field drops out of the query in the non-projection A/B mode (Views with calculated fields requireprojectionOnlyconnected stores).What to verify
Pct Total (calc)?on and a streaming update rate set, the View's diagnostics stay on the data-only update path (the old aggregator forced a full generation per tick).pctCommissioncells repaint on every tick, including rows whose own commission did not change (the moving-denominator case) - and leaf rows now show a real percent underLeaves?.pctCommissionstays correct across ticks; values match the old aggregator's at parent levels.developat high record multipliers - checks the generated dense/parent-row data classes hold V8 fast-properties shapes.Generated by Claude Code