Repository navigation
Replay missed auto-refreshes as auto-refreshes in onShowLazy mode - #4873
Merged
Merged
Conversation
ManagedRefreshContextModel replayed every missed refresh as a manual refresh when shown, dropping isAutoRefresh. The replay now stays an auto-refresh unless any missed refresh was manual.
…fresh # Conflicts: # CHANGELOG.md
✅ Unit tests passed - 1,392 tests1,392 tests · 120 spec files · 35 packages · 187.2s · commit 📊 Full report and all tests · interactive HTML report attached to the run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
onShowLazycontainer is hidden,ManagedRefreshContextModeldefers refreshes and replays one when the container is shown. That replay always went throughrefreshAsync(), so a missed background auto-refresh came back as a manual refresh. The result: error alerts and server logging, activity tracking, a load mask, and models that skip auto-refreshes (e.g.AlertBannerModelwith a dirty form) loading anyway.autoRefreshAsync()if so. A replay is manual if any missed refresh was manual.onShowAlwaysis unchanged - a refresh triggered by the user showing a tab stays manual.