Consolidate Admin Console sidebar tabs under General - #4759
Merged
Merged
Conversation
Splitting related admin views across top-level tabs gave no benefit once each had its own sidebar, so the General tab now holds them as sidebar groups. - Moved the Servers and User Data tabs into General, grouped as Application, Servers & Data, and Users & Roles. Their routes moved under `general`. - Moved JSON Blobs into the Servers & Data group, and put Metrics before Objects. - Moved the Clients tab next to Activity, and gave General a home icon. - Removed the unused `feedback` route. - Updated the Roles location in `docs/authorization.md`, and corrected its claim that the tab always shows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Admin Console had three top-level tabs - General, Servers, and User Data & Roles - that each opened their own left-hand tab bar. This PR puts all of their tabs into one grouped sidebar under General. The remaining top-level tabs (Monitors, Clients, and Activity) are complex, dedicated views, and they keep the full width of the viewport.
TabSwitchergroup headers./admin/general/.... Old/admin/servers/...and/admin/userData/...bookmarks no longer resolve.feedbackroute, and updated the Roles location indocs/authorization.md.To verify, run Toolbox with
pnpm startWithHoistand open/admin.developbranch as of last change.breaking-changelabel + CHANGELOG if so. Not breaking for the sample apps checked, which extendcreateTabs()andgetTabRoutes()only to add tabs.