Auto-include filterable columns in GridFilterModel fieldSpecs - #4756
Merged
Merged
Conversation
GridFilterModelConfig.fieldSpecs was all-or-nothing: providing a spec for any field disabled filters on all other filterable columns. GridFilterModel now creates a default spec for every filterable column not covered by the configured specs, including columns added later via setColumns(). Resolves #3429
- Also track bind.fieldNames so View query changes add specs for matching filterable columns. - Add brief description to CHANGELOG difficulty header and shorten entry. - Note in grid README that the column's field must exist in the bound Store or View.
…dSpecs # Conflicts: # CHANGELOG.md
lbwexler
self-requested a review
October 1, 2026 17:12
lbwexler
approved these changes
Oct 1, 2026
lbwexler
left a comment
lbwexler
left a comment
Member
There was a problem hiding this comment.
Approved -- waiting to merge until we aready to release the next major version
Member
Author
|
Agreed - thanks! |
…dSpecs # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3429.
Passing
fieldSpecstoGridFilterModelwas all-or-nothing. A spec for one field, e.g. to set a custom values renderer, left every otherfilterablecolumn without a filter.GridFilterModelnow adds a default spec for everyfilterablecolumn thatfieldSpecsomits, if its field exists in the bound Store or View.gridModel.columnsandbind.fieldNameskeeps specs in place for columns added viasetColumns()and for View query changes.fieldSpecDefaultsapply as before. Grids with nofieldSpecsare unchanged.fieldSpecsdoc comment, grid README, and CHANGELOG.Breaking change (LOW): apps that used
fieldSpecsas an allow-list alongsidecolDefaults: {filterable: true}will now see filters on the omitted columns. Setfilterable: falseon those columns to keep the old behavior.Tested in Toolbox admin column filter test pages (Store and Cube View binds), plus
setColumns()and destroy checks from the console.developbranch as of last change.breaking-changelabel + CHANGELOG if so.