Skip to content

CTaskGameCf - #28

Merged
CelestialAmber merged 5 commits into
xbret:mainfrom
Kelebek1:CTaskGameCf
Apr 13, 2026
Merged

CelestialAmber merged 5 commits into
xbret:mainfrom
Kelebek1:CTaskGameCf

Conversation

@Kelebek1

@Kelebek1 Kelebek1 commented Mar 27, 2026 •

Copy link
Copy Markdown
Contributor

CTaskGameCf is matching except for a small diff in 1 function.

Added a script ro run clang-format over the src folder since it's hard to get a list of filenames on Windows through the terminal. I ran it to format all the files according to the current .clang-format so we can get everything into a consistent format going forward.

@decomp-dev

decomp-dev Bot commented Mar 27, 2026 •

Copy link
Copy Markdown

Report for eu (4a91d8c - 72f7256)

📈 Matched code: 10.17% (+0.01%, +388 bytes)
📈 Matched data: 14.79% (+0.01%, +96 bytes)

✅ 9 new matches
Unit Item Bytes Before After
main/kyoshin/cf/CTaskGameCf extab +96 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::~CTaskGameCf() +84 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::~CTTask() +80 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Move() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Draw() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Term() +60 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::getInstance() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Init() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Draw() +4 0.00% 100.00%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogin() -1 0.95% 0.90%
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogout() 0 4.76% 4.52%

Report for jp (4a91d8c - 72f7256)

📈 Matched code: 10.46% (+0.04%, +2088 bytes)
📈 Matched data: 26.59% (+0.01%, +120 bytes)

✅ 27 new matches
Unit Item Bytes Before After
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_8004451C() +664 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::CTaskGameCf(CProcess*, int) +200 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_8004435C(short, short, ml::FixStr<32>&, short) +128 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::create(CProcess*, int) +108 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_80044934() +104 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf extab +96 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800448DC() +88 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::~CTaskGameCf() +84 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::~CTTask() +80 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Move() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Draw() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800442DC() +64 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Term() +60 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_80044444() +60 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800444A0() +60 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_8004431C() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_8004433C() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_80044424() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_80044480() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800444DC() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800444FC() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_8004499C() +32 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf .sdata +16 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf .sdata2 +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::getInstance() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Init() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Draw() +4 0.00% 100.00%
📈 5 improvements in unmatched items
Unit Item Bytes Before After
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::func_800447B4() +291 0.00% 98.45%
main/kyoshin/cf/CTaskGameCf .data +282 0.00% 95.48%
main/kyoshin/cf/CTaskGameCf extabindex +143 0.00% 99.31%
main/kyoshin/cf/CTaskGameCf .rodata +25 0.00% 62.50%
main/kyoshin/cf/CTaskGameCf .sbss +4 0.00% 50.00%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogin() -1 0.95% 0.90%
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogout() 0 4.76% 4.52%

Report for us (4a91d8c - 72f7256)

📈 Matched code: 10.17% (+0.01%, +388 bytes)
📈 Matched data: 14.79% (+0.01%, +96 bytes)

✅ 9 new matches
Unit Item Bytes Before After
main/kyoshin/cf/CTaskGameCf extab +96 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::~CTaskGameCf() +84 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::~CTTask() +80 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Move() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf CTTask<cf::CTaskGameCf>::Draw() +72 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Term() +60 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::getInstance() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Init() +8 0.00% 100.00%
main/kyoshin/cf/CTaskGameCf cf::CTaskGameCf::Draw() +4 0.00% 100.00%
📉 2 regressions in unmatched items
Unit Item Bytes Before After
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogin() -1 0.95% 0.90%
main/monolib/src/lib/CLibHbmControl CLibHbmControl::wkStandbyLogout() 0 4.76% 4.52%

@CelestialAmber
CelestialAmber merged commit c488317 into xbret:main Apr 13, 2026
3 checks passed
@CelestialAmber

Copy link
Copy Markdown
Collaborator

Thanks!

Aelbannan pushed a commit to Aelbannan/xenoblade that referenced this pull request Aug 3, 2026
* CTaskGameCf

* Post-process to remove the space between paren and brace

* Try manual fix

* Fixed?

* Ok headers too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants