Repository navigation
Conversation
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313.
math.minandmath.maxnow fall back to the VM's__ltlookup when a pair cannot use primitive ordering. The numeric/string path, exact mixed integer/float comparisons from #142, first-argument checks, tie handling and original result identity are retained.The fallback uses the existing async-native machinery. Arguments stay rooted in the native stack window; only slot indices cross calls, and only the comparator's first result is interpreted using Lua truthiness.
Adds eight regression cases checked against PUC Lua 5.5.1: tables and userdata, right-operand lookup/mixed types, truthiness, error-object propagation, GC and reentrant selection, live metatable changes, ties, and primitive/single-argument controls. Seven fail before the fix; all eight pass afterward.
Validation with the pinned Rust nightly
2026-04-05, Linux amd64:git diff --checkpasses.This branch is based directly on upstream
mainand is independent of the unpack fix in #314.