Skip to content

Fixes nonce & permissions check on admin page#168

Open
remyperona wants to merge 2 commits into
masterfrom
fix/nonce-permissions
Open

Fixes nonce & permissions check on admin page#168
remyperona wants to merge 2 commits into
masterfrom
fix/nonce-permissions

Conversation

@remyperona
Copy link
Copy Markdown

@remyperona remyperona commented May 28, 2026

This PR updates the Adminimize settings page handling to tighten nonce validation and capability checks for admin page POST actions, with an additional PHPCS ruleset metadata change.

Changes:

  • Moves nonce checks into the POST action conditions before dispatching settings, import, uninstall, and theme actions.
  • Replaces several array_key_exists()/truthy POST checks with isset() checks.
  • Updates phpcs.xml ruleset metadata and removes one whitespace sniff configuration.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Adminimize settings page handling to tighten nonce validation and capability checks for admin page POST actions, with an additional PHPCS ruleset metadata change.

Changes:

  • Moves nonce checks into the POST action conditions before dispatching settings, import, uninstall, and theme actions.
  • Replaces several array_key_exists()/truthy POST checks with isset() checks.
  • Updates phpcs.xml ruleset metadata and removes one whitespace sniff configuration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
adminimize_page.php Adjusts nonce and permission handling for settings page actions.
phpcs.xml Changes PHPCS ruleset metadata and removes a whitespace rule block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread phpcs.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants