Replace eval() in extract_subdir_path() with safe recursive path parser#6310
Draft
Replace eval() in extract_subdir_path() with safe recursive path parser#6310
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Agent-Logs-Url: https://github.com/wp-cli/wp-cli/sessions/8fd3eb62-47e5-402c-83f5-905362601e8d Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
…in dirname detection Agent-Logs-Url: https://github.com/wp-cli/wp-cli/sessions/8fd3eb62-47e5-402c-83f5-905362601e8d Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor extract_subdir_path to avoid eval usage in WP-CLI
Replace eval() in extract_subdir_path() with safe recursive path parser
Apr 27, 2026
This comment was marked as resolved.
This comment was marked as resolved.
…IR__ test case Agent-Logs-Url: https://github.com/wp-cli/wp-cli/sessions/32198f81-4601-4fa9-8363-645dc3851c24 Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval()inRunner::extract_subdir_path()with a safe path expression parserRunnerTest.phpPHPUnit tests (17 cases)dirname(__FILE__)and__DIR__variants<?php require __DIR__on one line breaks the^\s*requireregex — removed<?phpprefix to match the pattern used by the other test cases