Add retry for transient SGS request failures#58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
Adds retry with exponential backoff around the SGS HTTP request only, so transient transport failures such as read timeouts can recover without retrying status-code handling or response parsing.
The change covers both:
sgs.get_json()sgs.async_get_json()Verification
uv run pytest tests/test_sgs_negative.py tests/sgs/test_series.pyuv run pytest tests/test_async.pyuv run pytest -m "not integration"uv run pytest -m integrationuv run ruff check bcb/ tests/uv run ruff format --check bcb/ tests/uv run mypy bcb/uv run --group docs sphinx-build -b html docs docs/_build/html