release: bump 0.1.3 -> 0.1.4 - #124
Merged
Merged
Conversation
The registry entry for this package gained "branch": "*release", so the two places that described the old arrangement as a standing fact no longer match what happens. CONTRIBUTING.md said r-universe builds bindings/r from the default branch. It now says which release it builds and why that is the safe ref: configure resolves the C ABI from the release DESCRIPTION names, and a bump reaches main before that release exists. check_r_abi_skew.py justified its second, non-blocking check with "r-universe stays red until the next one". That consequence is gone -- the registry keeps serving the previous release instead. The check is unchanged and still warns; only the reason it gives is corrected.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits: the documentation that described how r-universe builds this package, and the version bump that ships the correction.
Why there is anything to correct
bindings/r/configuredownloads the C ABI from the GitHub release named byDESCRIPTION: Version. The registry tracked this repository's default branch, where a version bump lands before the release it names has been built -- so every build of a bump commit resolved a 404 and the deploy status went red.Over the last fourteen commits on
main, the three release bumps are the only red ones. The middle of them was spared because the builder does not pick up every commit, not because it would have worked.Nor is it a race a longer retry closes. 0.1.1 lost its GitHub release to a failed wasm publish, so
maincarried a version with no release at all and the registry stayed red until 0.1.2 replaced it.The registry entry now carries
"branch": "*release"(wickra-lib.r-universe.dev#1).release.ymldrafts a release, attaches every asset, and publishes it only after all eight publish jobs have succeeded -- so a tag becomes visible to the registry with its assets already attached, and a release that never completes leaves the previous one in service instead of breaking the current one.What this repository changes
Nothing that affects what the package installs. The registry lives in another repository; what changes here is that two files stated the old arrangement as a standing fact:
CONTRIBUTING.mdsaid r-universe buildsbindings/rfrom the default branch. It now says which release it builds, carries thebranchfield in the registry snippet, and gives the reason.scripts/check_r_abi_skew.pyjustified its second, non-blocking check with "r-universe stays red until the next one". That consequence no longer exists. The check is unchanged and still warns -- main being ahead of the last release is a release-readiness signal; it simply no longer breaks anything while it waits.Bump
bump_version.pyreports 21 declarations rewritten,scripts/check_version_sync.pyagrees on all 21. The only remaining0.1.3in the tree is a third-party crate that happens to be at0.1.34.Verification
cargo fmt --all-- no changescargo test --workspace --all-features-- 22 suites passcargo clippy --workspace --all-targets --all-features -- -D warnings-- cleanscripts/check_r_abi_skew.py-- wrapper links the released ABI unchanged