Track the release in the benchmarks pom and check it - #121
Merged
Conversation
bindings/java/benchmarks/pom.xml declared 0.1.0 for both its own artefact and the org.wickra:wickra-backtest dependency it builds against, while the project moved to 0.1.1 and then 0.1.2. The benchmarks therefore resolved a version that had stopped being current two releases earlier. scripts/check_version_sync.py runs on every push and passed throughout, because the file was never in its touchpoint list. A check can only fail on a file its list names, so a missing entry is silent rather than wrong -- the failure mode of a hand-maintained inventory is incompleteness, not error. Both occurrences now track the release and the file is checked at count 2, matching examples/java/pom.xml beside it. Keeping the module's own version on the release rather than leaving it independent also keeps the stale-version pass honest: a --previous 0.1.0 run would otherwise have reported the module's own 0.1.0 as a leftover.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
kingchenc
added a commit
that referenced
this pull request
Sep 2, 2026
Cuts 0.1.3 across the twenty version-bearing files this repository writes itself, and closes the changelog gap the previous release left open. ## Changelog `[Unreleased]` became `[0.1.3]`. One entry was missing from it and is added here: the `wickra-core` lockfile refresh from #122. The two entries already there -- the benchmarks pom that tracked a version deleted two releases ago (#121) and the publish gate that read a pending CI run as a failed one (#120) -- carry over unchanged. Everything merged since v0.1.2 is now described. `git log v0.1.2..main` lists exactly those three commits. ## Bump Run through `bump_version.py`, which reports 21 declarations rewritten: the workspace `Cargo.toml`, `Cargo.lock` via a real `cargo build`, the Python, Node (package, six platform stubs, lockfile, and the napi loader's version literal), Java, C# and R manifests, both poms that resolve the binding, `CITATION.cff` including its release date, and `SECURITY.md`'s supported-version table. `scripts/check_version_sync.py` agrees on all 21. The benchmarks pom is among them for the first time -- it was added to that check in #121, which is why this bump moves it rather than leaving it behind as 0.1.1 and 0.1.2 did. A grep for `0.1.2` outside the changelog returns one hit, `iana-time-zone-haiku`, whose own version happens to be the same string. ## Verification - `cargo fmt --all` -- no changes - `cargo test --workspace --all-features` -- all suites pass - `cargo clippy --workspace --all-targets --all-features -- -D warnings` -- clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bindings/java/benchmarks/pom.xmldeclared0.1.0for both its own artefact and theorg.wickra:wickra-backtestdependency it builds against, while the project moved to 0.1.1 and then 0.1.2. The benchmarks resolved a version that had stopped being current two releases earlier.Why CI never said anything
scripts/check_version_sync.pyruns on every push and passed throughout. The file was not in its touchpoint list, and a check can only fail on a file its list names -- the failure mode of a hand-maintained inventory is incompleteness, not error, and incompleteness makes no noise.It was found by the org-wide version scan in
wickra-lib/.github, which derives its file set from the repository instead of listing it.The fix
Both occurrences now track the release, and the file is checked at count 2 -- the same shape as
examples/java/pom.xmlbeside it.Keeping the module's own version on the release, rather than leaving it independent the way wickra's benchmarks pom does, also keeps the stale pass honest: a
--previous 0.1.0run would otherwise have reported the module's own0.1.0as a leftover.Verified
Also passes
--previous 0.1.1and--previous 0.1.0.