Skip to content

Set navigation conditions potentially changed when setting cookie - #302

Open
llannasatoll wants to merge 3 commits into
whatwg:mainfrom
llannasatoll:navigation-conditions-changed
Open

llannasatoll wants to merge 3 commits into
whatwg:mainfrom
llannasatoll:navigation-conditions-changed

Conversation

@llannasatoll

@llannasatoll llannasatoll commented Jul 21, 2026 •

Copy link
Copy Markdown

This PR updates the spec to invoke the mark navigation conditions as potentially changed abstract operation introduced in whatwg/html#11765 upon client-side cookie (document.cookie and CookieStore) modifications.

(See WHATWG Working Mode: Changes for more details.)


💥 Error: 422 Unprocessable Entity 💥

PR Preview failed to build. (Last tried on Oct 20, 2026, 12:52 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build bikeshed/ReSpec specs

🔗 Related URL

Error output:

[
    {
        "lineNum": "658:45",
        "messageType": "link",
        "text": "No 'dfn' refs found for 'mark navigation conditions as potentially changed'."
    },
    {
        "lineNum": null,
        "messageType": "failure",
        "text": "Did not generate, due to errors exceeding the allowed error level."
    }
]

This seems to be an issue with the Spec Generator service. PR Preview doesn't manage this service and so has no control over it. If you've identified an issue with it, you can report the issue to the maintainers of Spec Generator directly. Please be courteous. Thank you!

If you don't have enough information above to solve the error by yourself or if the issue doesn't seem related to Spec Generator, you can file an issue with PR Preview.

@DCtheTall

Copy link
Copy Markdown
Member

This feature seems to apply to all cookies, not just the Cookie Store API. It probably makes sense to update the spec in one place where the cookie storage model is invoked.

@annevk I think this type of thing belongs in Fetch when we move more of the cookie spec into that. The flag in this feature would be a side effect of Cookie Store API calling methods in the Fetch spec, since I do not see a reason this API needs to be aware of this flag. WDYT?

@annevk

annevk commented Aug 23, 2026

Copy link
Copy Markdown
Member

I think it's just cookie APIs (so this and document.cookie) that can cause this flag to be set. Not anything network-based. If that's correct having it here might be okay, though perhaps we should still have an abstraction that all APIs can use that takes care of this.

@llannasatoll

Copy link
Copy Markdown
Author

I'm sorry for the long delay. I now have updated the PR to invoke the new mark navigation conditions as potentially changed abstract operation defined in whatwg/html#11765. This removes the need for the Cookie Store API to manually inspect the Window and Document navigable flags. Could you take another look?

@DCtheTall DCtheTall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution and apologies for the delay myself 😄

Comment thread index.bs Outdated
@llannasatoll
llannasatoll force-pushed the navigation-conditions-changed branch from 7976d20 to bcf1b58 Compare October 20, 2026 12:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants