Repository navigation
fix: preserve unresolved protocol imports in vite analysis - #464
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-3c35c771-6a5e-4faa-8e3c-f65132d6bb64 Co-authored-by: tmm <tmm@tmm.dev>
Contributor
|
|
commit: |
Contributor
Contributor
Site previewCommit: |
Contributor
Benchmark Report🟢 Zyzz passes the framework gate in all 11 workloads. Every workload compiles from fresh compiler state, including Lightning CSS minification and esbuild client bundling. Lower is better, bold marks the best result in each row, and the ratio beside each competitor compares its result with Zyzz. Compile TimeMean milliseconds per compilation.
CSS SizeGzip bytes of the minified stylesheet.
JS SizeGzip bytes of the bundled client JavaScript, including required runtime helpers.
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zyzz rejected server-only protocol imports before TanStack Start could remove them from client code. Unresolved protocols now stay runtime-only, while resolvable aliases remain analyzable and missing ordinary files and packages still fail.
For example,
import { env } from "cloudflare:workers"used only insidecreateIsomorphicFn().server(...)no longer needs a dynamic-import workaround. Includes a patch changeset written in past tense.Validation: the regression failed before the fix. All 60 Vite integration tests passed with V8 coverage (94.58% Vite plugin line coverage), plus scoped type checks, formatting/lint, and diff checks. The full type check exceeded orb memory limits. An initial concurrent suite run had three timeouts, and the unchanged suite passed sequentially.