Repository navigation
fix: #15 Back up this project leaves out the database of a site that has none, and no empty dump behind - #16
Merged
Conversation
…has none, and no empty dump behind AI-Generated: Yes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 16, 2026
Member
Author
|
Proved in round 4 of the testing rounds on a real Astro site ( Published 1.0.9 command: and This branch's command in place: and only the archive. That backup, restored after the site was removed (with webship/workspace#355): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15
commands/cmd-tools-backup-dev.sharchived the project and then always randdev export-db. On a site that runs without a database (Astro, Gatsby:omit_containers: [db]) DDEV answeredservice db does not existwith the whole help ofexport-db, and left a…-db.sql.gzof 0 bytes beside the archive, which a restore then tried to import (webship/workspace#354). Seen in round 4 of the testing rounds on an Astro and a Gatsby site built from the dashboard..ddev/config.yaml(or aconfig.*.yamlbeside it) omitsdbhas its files backed up and the line<site> runs without a database: its files are backed up, and there is no database to export.; no export is tried, exit 0.ddev export-dbfails, the empty dump it left is removed and the backup saysThe database of <site> could not be exported: only its files are backed up.(exit 1, as before).tests/backup.test.ts: three tests that run the command with a stand-in bootstrap and addevthat does what DDEV does on export (an empty file first). Two of them fail on the old command (no database; failed export), the third holds the unchanged path.npm run lintclean;npm test: 16 pass, 0 fail.Checkpoints
🤖 Generated with Claude Code