Skip to content

Fix provider duplicate lifecycle - #2818

Merged
webbrain-one merged 1 commit into
mainfrom
agent/fix-provider-duplicate-lifecycle
Aug 16, 2026
Merged

Fix provider duplicate lifecycle#2818
webbrain-one merged 1 commit into
mainfrom
agent/fix-provider-duplicate-lifecycle

Conversation

@esokullu

Copy link
Copy Markdown
Collaborator

Summary

  • disable Duplicate until a provider is saved and whenever its settings have unsaved edits
  • stop Duplicate from implicitly saving drafts and reject or purge pre-Save duplicates in the provider manager
  • place each duplicate immediately after its source across Settings and provider pickers
  • keep Chrome and Firefox behavior and localized guidance in sync

Root cause

Duplicate creation saved current drafts with markConfigured: false, so a copy could be persisted before the user explicitly saved the source. Provider output also followed map insertion order, which appended duplicates at the end.

Impact

Users now get a predictable source → duplicate layout and cannot clone stale or unsaved provider configuration.

Validation

  • node test/run.js — 1780 passed, 0 failed
  • npm run test:toolbar-guard — 33 passed
  • npm run test:security — 60/60 passed
  • git diff --cached --check

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webbrain Ready Ready Preview Aug 16, 2026 9:18am

Request Review

@esokullu
esokullu marked this pull request as ready for review August 16, 2026 09:18
@webbrain-one
webbrain-one merged commit 3ab733f into main Aug 16, 2026
7 checks passed
@webbrain-one
webbrain-one deleted the agent/fix-provider-duplicate-lifecycle branch August 16, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants