Repository navigation
Add BookingProject, ContactDetailsGroup and some other small features - #67
Conversation
|
I also noted, that invNumber has not to be required for InvoiceCreate. That makes it possible to let easyverein calculate the next invoice number. So I implemented that |
waza-ari
left a comment
There was a problem hiding this comment.
Hey @Blumenkind111 , my apologies for coming back so late. I've finally found the time to go through the PR. First of all, much appreciate your time and commitment adding those two endpoints!
Added a few comments in the review, only one somewhat "major". Would appreciate an update and rebase onto main, although there should be no breaking changes.
Also, let's update the docs folder for those new endpoints. Check the existing ones, most of that is auto-generated so it should be quite quick. Happy to merge afterwards!
|
Hi, thanks for the thorough feedback 👍 I included the proposed changes and in the meantime added some more features. I also deleted everything in my branch while trying to update it. Not too familiar with git 😵 I am happy to do more changes if the code does not meet the project standard! I fixed all comments. Also did some actualization of the docs. The autogenerated part has been done by my bot, because i did not know how ... Together we also updated some outdated parts in the readme and global docs files. |
- made the count initial state based. This is more robust, when the test db is corrupted (which mine often is) - Add Tests for closingDescription - modify test vor invNumber not needed
…for booking creation exclude_default instead of exclude_none in search serialization. Did not break any tests
…rect handling of non ascii chars (f.e. '&') , including a test
Sadly, there does not seem to be a way to do the group assignments via api
it is an undocumented feature ...
… groups - keep receiver required on BookingCreate, the API rejects missing and empty receivers; restore it in the minimal booking test - remove wrong methodOfPayment TODO, the API returns ints 0-4 - accept decimals and zero in BookingProjectFilter budget__lt/budget__gt - build get_all() filters with exclude_none, consistent with get() - drop type: ignore comments by typing selectedOptions payload correctly - fix ContactDetailsGroup docstrings copied from member groups - make the contact details search test create and clean up its own record Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks a lot again for this PR! I went through it, ran the tests suite against our demo account and found a few things. They were small, so rather than send everything back I rebased the branch and pushed the fixes on top myself. As a summary, here is what I changed. Review findings
All 61 tests pass against the demo account, and lint and mypy are clean. Thanks again for the work you put into this! |
I added the BookingProject to python-easyverein.
Also rewrote the url construction, that it may parse special letters like "&" correctly + some minor fixes
If needed i can update the docs, but cannot promise, i will get to it in time :)