Repository navigation
Conversation
dlongley
left a comment
dlongley
left a comment
There was a problem hiding this comment.
Approving, but note that I think an exception/error is probably better for the timeout case. I think it might be confusing to return empty chains -- which seems to be an implicit signal of a timeout error (which might be confused with other conditions?) rather than just being explicit.
| at any depth gains the ability to assert recognition claims that propagate | ||
| upward through the entire chain to [=E4|verifiers=] that have configured | ||
| only a top-level trust anchor. | ||
| only a top-level trust anchor. Depth limits bound one chain. They do not |
There was a problem hiding this comment.
Just noting another "trust anchor" use.
There was a problem hiding this comment.
Yeah, need to do a blanket fix of these across the spec, they've gotten out of control. Will change to "recognition anchor" once all these security/privacy PRs have landed.
| <var>credential</var> followed by the elements of the returned chain to | ||
| <var>chains</var>. | ||
| <var>chains</var>. If the elapsed time since this algorithm started exceeds | ||
| <var>maxDuration</var>, return an empty list. |
There was a problem hiding this comment.
I think it would be better to throw a TimeoutError instead of returning an empty list.
Attempted fix in c678521. |
This is an attempt at a fix for issue M-05 from the Security Review by SING: w3c/security-request#141 (comment)
/cc @simoneonofri
Preview | Diff