Skip to content

[editorial] fixed wrongly rendered line#642

Merged
himorin merged 4 commits into
mainfrom
himorin/20260330-id-fix
Apr 3, 2026
Merged

[editorial] fixed wrongly rendered line#642
himorin merged 4 commits into
mainfrom
himorin/20260330-id-fix

Conversation

@himorin

@himorin himorin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

as title, non-normative
fixing wrongly rendered part between section 7 and 8


Preview | Diff

@nigelmegitt nigelmegitt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like @palemieux 's view on this as Editor - it might be enough to just change the <a> to a <div> without moving the line.

@himorin

himorin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

I'd have all content within <section>, per https://respec.org/docs/#sections

Wrap content in <section> elements. ReSpec handles numbering, IDs, and ToC entries automatically.

@nigelmegitt

Copy link
Copy Markdown
Contributor

I'd have all content within <section>

This doesn't have any content in it though, it's just a place to put a fragment id. It probably doesn't matter much either way, in practice.

@himorin

himorin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

@nigelmegitt I'd agree just a place to put a fragment id, if we (not respec expert) could clearly and immediately describe why current line turned into rendering by respec... but if we cannot, I suppose it's kind of skate on thin ice...

<a id="text-profile-constraints"></a>

   <a id="text-profile-constraints"></a>
  <section id='common-constraints'>

https://www.w3.org/TR/2026/CRD-ttml-imsc1.3-20260226/ (line 2312)

 <a id="text-profile-constraints" data-link-type="dfn" data-cite-href="https://www.w3.org/TR/CSS2/selector.html#x18" href="[https://www.w3.org/TR/CSS2/selector.html#x18](view-source:https://www.w3.org/TR/CSS2/selector.html#x18)">CSS Snapshot 2026</a>
  <section id="common-constraints"><div class="header-wrapper"><h2 id="x8-additional-provisions"><bdi class="secno">8. </bdi>Additional Provisions</h2><a class="self-link" href="[#common-constraints](view-source:https://www.w3.org/TR/2026/CRD-ttml-imsc1.3-20260226/#common-constraints)" aria-label="Permalink for Section 8."></a></div>

@nigelmegitt

Copy link
Copy Markdown
Contributor

@himorin I'm certain that's an accidental import, maybe even a weird bug in Respec, caused when it tried to dereference that id="text-profile-constraints" and found something in a cited specification rather than in the current document, where it historically existed.

@palemieux palemieux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All anchors to similar legacy sections should be consistent, e.g., all empty <spans> instead of <a>

@nigelmegitt

Copy link
Copy Markdown
Contributor

All anchors to similar legacy sections should be consistent, e.g., all empty <spans> instead of <a>

I can't see any other <a id=... links anywhere - can you?

There are the <div id=... anchor holders at lines 4162-4171 - are you suggesting changing those to span for consistency @palemieux ?

@himorin

himorin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

as @nigelmegitt pointed during conversation in email, existing lines uses div, and also there seems no line with <span id= per search.

@palemieux

Copy link
Copy Markdown
Contributor

as @nigelmegitt pointed during conversation in email, existing lines uses div, and also there seems no line with <span id= per search.

Let's use <div> then! Thanks.

@himorin

himorin commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@palemieux so, ok to merge? (you are blocking with changes requested)

@palemieux palemieux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a div.

Comment thread imsc1/spec/ttml-ww-profiles.html Outdated
Comment thread imsc1/spec/ttml-ww-profiles.html
@palemieux

Copy link
Copy Markdown
Contributor

@palemieux so, ok to merge? (you are blocking with changes requested)

We should use a div instead of a span to match the rest of the document, e.g.,

<!-- Preserves links to document fragments made to previous versions of IMSC through IMSC's undated URL, e.g.,

@himorin

himorin commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@palemieux so, ok to merge? (you are blocking with changes requested)

We should use a div instead of a span to match the rest of the document, e.g.,

<!-- Preserves links to document fragments made to previous versions of IMSC through IMSC's undated URL, e.g.,

I'm quite sorry. I've totally mis-understood what I've wrote in this PR...

@himorin

himorin commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@palemieux believe, should be fine now...

@palemieux

Copy link
Copy Markdown
Contributor

@himorin I added a comment and moved the div above the section to match the other use in the specification. Feel free to merge if ok with you.

@himorin

himorin commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@palemieux hope nothing will happen with ignoring order in respec document/manual ;)

@himorin himorin merged commit 0865eb7 into main Apr 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants