Repository navigation
Addition: fix the long-standing gap of how th scope=rowgroup should be mapped to align with HTML semantics - #2950
Open
scottaohara wants to merge 3 commits into
Open
scottaohara wants to merge 3 commits into
scottaohara wants to merge 3 commits into
Conversation
a `th scope=rowheader` is meant to serve as a way to label (name) a [Row Group](https://html.spec.whatwg.org/multipage/tables.html#attr-th-scope-rowgroup) in HTML there's also `scope=colgroup` / the concept of a Column Group in HTML - but i have zero idea how that fits in with the current reality that LOL, the fact `rowgroup` exists is barely recognized by AT (if at all).... so that's purposefully not part of this PR.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
🚀 Deployed on https://deploy-preview-2950--wai-aria.netlify.app |
update mappings for `thead`, `tfoot` and `tbody` to identify that the first descendent `th scope=rowheader` is meant to provide these elements their accessible name. matched other similar labelldby relationships (e.g., fieldset to legend) but the difference here is that the `th` elements is _not_ a direct child of the `thead`, `tfoot` or `tbody` elements
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Netlify Preview:
🔄 this PR updates the following specs: