Red Brinstar Fireflea Room: low energy spark to block - #2972
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are self-contained data additions with consistent schema usage (new strats without IDs, notable added with updated nextNotableId) and no detected structural issues.
Pull request overview
Adds a new “Low Energy Spark to Block” technique/strat option for Red Brinstar Fireflea Room, expanding the room’s shinespark routing logic to account for intentionally low-energy horizontal midair sparks.
Changes:
- Added two new strats for reaching the block via a low-energy midair horizontal shinespark when entering shinecharged or shinecharging.
- Added a corresponding notable (“Low Energy Spark to Block”) and advanced
nextNotableId.
File summaries
| File | Description |
|---|---|
| region/brinstar/red/Red Brinstar Fireflea Room.json | Adds new low-energy shinespark strats and a notable to document/enable the technique. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kjbranch
left a comment
kjbranch
left a comment
There was a problem hiding this comment.
This needs a much more detailed description.
- where to spark from
- mention that being higher gives more wiggle room when falling
| {"shineChargeFrames": 42}, | ||
| "canHorizontalMidairShinespark", | ||
| {"resourceAtMost": [{"type": "RegularEnergy", "count": 99}]}, | ||
| {"shinespark": {"frames": 70, "excessFrames": 4}} |
There was a problem hiding this comment.
I think with these excess frames, you would need to start in a different position, which is then canControllShinesparkEnd.
| {"shinespark": {"frames": 70, "excessFrames": 4}} | |
| {"shinespark": {"frames": 70, "excessFrames": 0}} |
There was a problem hiding this comment.
When I was testing this out, I was normalizing the start position to be close to the ceiling, and 2-3 tiles right of the end of the platform. So then from that start, with 95-99 hp I was close enough to the block to fall into it by holding left or right. So this line was me trying to reflect what I tested, but I'm not dogmatic about it, we could just say you need exactly 99.
There was a problem hiding this comment.
Re-testing, at 95 you need a pretty big jump forward. So I think your inclination to just normalize at 99 is probably right. With 99 energy, the startup position is incredibly lenient, anywhere from directly over the last platform tile, up to 6 tiles out, works as long as you're close to the ceiling.
There was a problem hiding this comment.
Basically there's a 7-tile window that works, because ending the spark anywhere from -3 to +3 allows you to fall onto to the block.
True, in my head I was imagining that it's paired with a video; but I'll call this out in more detail. |
|
Updated the description, removed the excess frames. |
https://discord.com/channels/1053421401354285129/1053436236628496454/1546988210985631864
Similar to #2963 - add a strat to allow 99 energy spark.