fix(provider): validate JSON-compatible objects and values - #21232
Open
halvaradop wants to merge 5 commits into
Open
halvaradop wants to merge 5 commits into
halvaradop wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves JSON-compatible value validation through the
isJSONObjectfunction.The function now verifies that the provided value contains only JSON-compatible values, including JSON primitives, arrays, and plain objects. It rejects unsupported values such as functions, symbols, bigints, and non-plain objects such as class instances,
Date, andRegExpobjects.Additionally, this PR re-exports the new
isPlainObjectfunction, which verifies whether a value is a plain object.Previously,
isJSONObjectaccepted values such asDate,RegExp, and other objects that inherit from custom prototypes or classes.Package Structure
The
is-json.tsimplementation could potentially be moved to theprovider-utilspackage.The
providerpackage primarily contains provider definitions and types, whileprovider-utilscontains provider-related logic and utility functions. Moving this implementation toprovider-utilswould keep the package responsibilities more consistent.Checklist
pnpm changesetin the project root)