fix: repair CI build with ameba 1.7 - #46
Merged
Merged
Conversation
veelenga
force-pushed
the
fix/ameba-build
branch
from
August 9, 2026 08:43
11b044a to
861c67a
Compare
Ameba 1.6.4 fails to compile with recent Crystal (next_string_array_token was removed from Crystal::Lexer). The 1.7 line drops the postinstall binary in favor of the lib/ameba/bin/ameba.cr entry script, so the CI linter step now compiles and runs it via crystal.
Autocorrected new-rule offenses (percent literal delimiters, macro expression whitespace, be_true/be_false/be_nil spec expectations, redundant self) and disabled Style/MultilineStringLiteral, since %q(...) literals are used intentionally for embedded Lua snippets.
veelenga
force-pushed
the
fix/ameba-build
branch
from
August 9, 2026 08:43
861c67a to
e88a519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
next_string_array_tokenwas removed fromCrystal::Lexer)crystal run bin/ameba.cr, since ameba 1.7 ships an entry script instead of a postinstall-built binarybe_true/be_nilspec expectations, redundantself)Style/MultilineStringLiteral—%q(...)literals are intentional for embedded Lua snippets