Skip to content

BMS - vc_charge_start can be set higher than vc_charge_end #462

Description

@Seminko

I believe users should not be allowed to set vc_charge_start higher than vc_charge_end. Currently we are.
This can lead to overcharging in some scenarios.
Created a check for that in /vedderb/vesc_pkg/vbms32_micro/vbms32_micro.lisp

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions