Repository navigation
Conversation
matiyau
changed the title
matiyau
changed the title
matiyau
force-pushed
the
add-support-for-wireless-switch-battery-status
branch
6 times, most recently
from
October 3, 2026 23:47
011daa7 to
1d31059
Compare
(SwitchType can now be used for road shifter, TT shifter, etc.)
matiyau
force-pushed
the
add-support-for-wireless-switch-battery-status
branch
from
October 4, 2026 00:32
1d31059 to
fb57c8d
Compare
…rete levels (unknown/low/mid/high) instead of a percentage.
matiyau
force-pushed
the
add-support-for-wireless-switch-battery-status
branch
4 times, most recently
from
October 4, 2026 21:31
2334d30 to
cde9134
Compare
matiyau
commented
Oct 4, 2026
matiyau
commented
Oct 4, 2026
| <string name="text_signal">Signal</string> | ||
| <string name="text_connection_status">Connection Status</string> | ||
| <string name="text_battery">Battery</string> | ||
| <string name="text_main_battery">Main Battery</string> |
Author
There was a problem hiding this comment.
Not really sure what to call this one: Main Battery/Central Battery/System Battery?
Owner
There was a problem hiding this comment.
Maybe Shifting Battery? Also not sure...
matiyau
commented
Oct 4, 2026
matiyau
commented
Oct 4, 2026
matiyau
commented
Oct 4, 2026
matiyau
commented
Oct 4, 2026
matiyau
force-pushed
the
add-support-for-wireless-switch-battery-status
branch
from
October 4, 2026 22:48
cde9134 to
6da6ac6
Compare
matiyau
force-pushed
the
add-support-for-wireless-switch-battery-status
branch
from
October 4, 2026 23:02
6da6ac6 to
fc0a411
Compare
matiyau
commented
Oct 4, 2026
matiyau
marked this pull request as ready for review
October 4, 2026 23:11
matiyau
changed the title
valterc
reviewed
Oct 8, 2026
valterc
left a comment
valterc
left a comment
Owner
There was a problem hiding this comment.
This is great, thanks!
Looks good overall, some minor comments. Still need to give it a try in Karoo.
Comment on lines
+76
to
+79
| lowBatteryRecords.filter { !it.alertedInRide }.forEach { alertRecord -> | ||
| alertRecord.alertedInRide = true | ||
| alertInRide(alertRecord) | ||
| } |
Owner
There was a problem hiding this comment.
Haven't tried it, how does it look when multiple wireless switches have low battery? Would it be better to send a single InRideAlert with all low battery switches like you do for the SystemNotification?
| <string name="summary_preference_ant_recording">Record all ANT events and data into a file for debugging</string> | ||
| <string name="summary_preference_fit_recording_device_info">Record identifiers of the Di2 device in use into the ride FIT file</string> | ||
| <string name="summary_preference_battery_notification">Show notifications when the shifting battery level is at or below a certain value</string> | ||
| <string name="summary_preference_battery_notification">Show notifications when the main battery level is at or below a certain value, or when a wireless switch battery is low</string> |
Owner
There was a problem hiding this comment.
Suggested change
| <string name="summary_preference_battery_notification">Show notifications when the main battery level is at or below a certain value, or when a wireless switch battery is low</string> | |
| <string name="summary_preference_battery_notification">Show notifications when the shifting battery level is at or below a certain value, or when a wireless switch battery is low</string> |
Maybe keep shifting battery?
Comment on lines
+60
to
+69
| val stateLock = Any() | ||
| var state = ViewState() | ||
| val states = Channel<ViewState>(Channel.CONFLATED) | ||
|
|
||
| fun updateState(transform: (ViewState) -> ViewState) { | ||
| synchronized(stateLock) { | ||
| state = transform(state) | ||
| states.trySend(state) | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
Suggested change
| val stateLock = Any() | |
| var state = ViewState() | |
| val states = Channel<ViewState>(Channel.CONFLATED) | |
| fun updateState(transform: (ViewState) -> ViewState) { | |
| synchronized(stateLock) { | |
| state = transform(state) | |
| states.trySend(state) | |
| } | |
| } | |
| var state = ViewState() | |
| val states = Channel<ViewState>(Channel.CONFLATED) | |
| fun updateState(transform: (ViewState) -> ViewState) { | |
| state = transform(state) | |
| states.trySend(state) | |
| } |
Not sure why we need the synchronized?
Comment on lines
+418
to
+422
| <LinearLayout | ||
| android:id="@+id/linearlayout_device_details_wireless_switch_batteries" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical" /> |
Owner
There was a problem hiding this comment.
I'll give it a try, what is displayed for systems without wireless switches?
| <string name="text_signal">Signal</string> | ||
| <string name="text_connection_status">Connection Status</string> | ||
| <string name="text_battery">Battery</string> | ||
| <string name="text_main_battery">Main Battery</string> |
Owner
There was a problem hiding this comment.
Maybe Shifting Battery? Also not sure...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Issue #313] This PR adds battery indicators and low-battery notifications/alerts for wireless switches.