Repository navigation
shorter cache policy for non-200s and sws non-term urls - #576
Merged
Merged
Conversation
Coverage Report for CI Build 35286738921Coverage increased (+0.04%) to 79.084%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cache policy changes are focused, consistent, and covered by corresponding tests.
Pull request overview
Updates cache expiration policies for SWS responses and pins npm during the frontend build.
Changes:
- Cache non-200 responses for seven minutes.
- Cache SWS term URLs for one day and other SWS URLs for 15 minutes.
- Add coverage for the new cache policies and update npm.
File summaries
| File | Description |
|---|---|
Dockerfile |
Pins npm 11.19.1 for frontend installation. |
compass/cache.py |
Implements updated cache expiration rules. |
compass/tests/test_cache.py |
Tests term, non-term, and non-200 SWS caching. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jlaney
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.