docs: fix broken links in SDK READMEs and moss-pikachu skill - #484
Closed
thefounderluke wants to merge 2 commits into
Closed
docs: fix broken links in SDK READMEs and moss-pikachu skill#484thefounderluke wants to merge 2 commits into
thefounderluke wants to merge 2 commits into
Conversation
- sdks/javascript/README.md: license link pointed at sdk/LICENSE.txt; the file is sdk/LICENSE (matches every other SDK README). - sdks/python/sdk/README.md: metadata-filtering example link was one directory level short (../../ instead of ../../../). - sdks/javascript/sdk/README.md: remove reference to samples/metadata-filtering.ts, which does not exist in the samples directory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
../../how-to.md resolved inside .cursor/; the file lives at the example root, three levels up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codex reviewNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
A sweep of all 195 markdown files in the repo for relative links that don't resolve turned up a handful of broken ones. This PR fixes the four with unambiguous targets:
sdks/javascript/README.md: license link pointed atsdk/LICENSE.txt; the file issdk/LICENSE(every other SDK README already links it without the extension).sdks/python/sdk/README.md: the metadata-filtering example link was one directory level short (../../instead of../../../) — the target file exists.sdks/javascript/sdk/README.md: removed the reference tosamples/metadata-filtering.ts, which doesn't exist in the samples directory. (If docs(examples): add metadata filter operator snippets #438 lands its runnable metadata-filter examples underexamples/javascript/metadata-filters/, this sentence could be reinstated pointing there instead — happy to do that follow-up.)examples/moss-pikachu/.cursor/skills/moss-pikachu/SKILL.md:how-to.mdlink was one level short; the file lives at the example root.The sweep also found references in
examples/moss-pikachu(project-summary.md,contribution.md, and three sibling skill files) that don't exist anywhere in the repo — I've left those alone rather than guess at the intent.All four fixed targets verified to exist; re-ran the link check on the changed files — zero broken relative links remain.