build(deps): refresh brace-expansion to latest - #478
Conversation
|
@codex review |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (8)
- apps/livekit-moss-vercel/agent-react/pnpm-lock.yaml: Generated file
- apps/next-js/package-lock.json: Generated file
- examples/javascript/package-lock.json: Generated file
- examples/moss-pikachu/promo/package-lock.json: Generated file
- examples/voice-agents/insurance-adjuster/ui/package-lock.json: Generated file
- moss-live-labs/examples/image-search/react-app/package-lock.json: Generated file
- packages/vitepress-plugin-moss/pnpm-lock.yaml: Generated file
- sdks/javascript/sdk/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "node_modules/postcss": { | ||
| "version": "8.5.19", | ||
| "resolved": "https://registry.npmjs.org/postcss/-/postcss-8.5.19.tgz", | ||
| "integrity": "sha512-Mz8SaolMd8nB+G13WkORcxQKHZ/NE4xXevtkJHVuG+guo9/wYKlIMTKAqGdEmYOXR2ijPjTYNHssizdaVSUNdQ==", | ||
| "dev": true, | ||
| "funding": [ |
|
/review |
Codex reviewNo issues found. |
|
@HarshaNalluru This CI issue is pre-existing Root cause is that pip install ruff has no version pin, and ruff just released 0.16.0 which expanded its default rule set. With 0.16.0, ruff check . fails with 475 errors across pre-existing files. Should i raise a new issue and fix it there? |
|
checks failing |
? |
PTAL at the above comment. |
|
@rohanshrma222 thanks for the flag, make a new PR to fix that issue and come back to this |
That issue was already fixed in another PR. |
Pull Request Checklist
Please ensure that your PR meets the following requirements:
Description
Refreshes the transitive
brace-expansiondependency (pulled in everywhere via various versions ofminimatch) across every lockfile in the repo where it had drifted out of date, to avoid drift in glob/pattern handling as rbrace-expansionis 100% transitive here nopackage.jsondecs a pure lockfile refresh with nopackage.json/overrideschanges. Three major lines are in play depending on whichminimatchversion resolves it in a given project; each was bumped to its latest currently-safe patch:1.x→1.1.162.x→2.1.25.x→5.0.7(not5.0.8— that release was published only is rejected by this repo's own pnpmminimumReleaseAgesupply-chain policy;5.0.7is the latest release that clears it)Files touched:
apps/next-js,examples/javascript,examples/moss-pikachu/promo,examples/voice-agents/insurance-adjuster/ui,moss-live-labs/examples/image-search/react-app,sdks/javascriprcel/agent-react(pnpm),packages/vitepress-plugin-moss(pnpm).apps/moss-vscodeand itspromo/sibling needed no change — already current.Verified per-project via lint/typecheck/build/test where the environment allowed; all failures encountered were confirmed pre-existing by reproducing them
against the original, unmodified lockfiles.
sdks/javascript/sdkstall in this environment (needs a Rust-built native binaryunrelated to this change), so that lockfile was validated via JSON-parse only.Fixes #469
Type of Change